Use the waitForEvent helper function in the text layer integration tests#18555
Conversation
…tests The `waitForClick` helper function is functionality-wise mostly a reduced copy of the more generic `waitForEvent` helper function that we use for other integration tests, so we can safely replace it to reduce the amount of code. Moreover, the `waitForClick` code is prone to intermittent failures given recent assertion failures we have seen on the bots (one of them is linked in mozilla#18396) while `waitForEvent` has recently been fixed to avoid intermittent failures, so usiong it should also get rid of the flakiness for these integration tests.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7eb280a10c83d87/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/f44a0df18d03a54/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7eb280a10c83d87/output.txt Total script time: 8.70 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f44a0df18d03a54/output.txt Total script time: 18.18 mins
|
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up, and sorry for having introduced the flake! The reason I originally introduced a new helper was that I didn't realize I could use the "validator" to call e.preventDefault().
|
@nicolo-ribaudo No worries; I also didn't catch this during review, and such intermittent issues unfortunately often only tend to show up after a number of runs, and on the slower bot which makes it hard to reproduce locally. |
The
waitForClickhelper function is functionality-wise mostly a reduced copy of the more genericwaitForEventhelper function that we use for other integration tests, so we can safely replace it to reduce the amount of code.Moreover, the
waitForClickcode is prone to intermittent failures given recent assertion failures we have seen on the bots (one of them is linked in #18396) whilewaitForEventhas recently been fixed to avoid intermittent failures, so usiong it should also get rid of the flakiness for these integration tests.Fixes a part of #18396.