Remove the eslint-plugin-mozilla dependency#18583
Merged
Merged
Conversation
We only used two rules from the plugin which can both easily be replaced nowadays: - `mozilla/avoid-removeChild` is equal to the already active `unicorn/prefer-dom-node-remove` rule; please see [1] and [2]. - `mozilla/import-globals` is mostly obsolete nowadays ever since we removed the Firefox extension code from this repository and we eliminated most globals usage. The three remaining occurrences can be replaced with explicit `/* globals */` comments that we already use elsewhere, which overall is also more consistent. [1] https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint-plugin-mozilla/rules/avoid-removeChild.html [2] https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-remove.md
Snuffleupagus
approved these changes
Aug 8, 2024
Snuffleupagus
left a comment
Collaborator
There was a problem hiding this comment.
r=me, fewer dependencies are always nice; thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only used two rules from the plugin which can both easily be replaced nowadays:
mozilla/avoid-removeChildis equal to the already activeunicorn/prefer-dom-node-removerule; please see [1] and [2].mozilla/import-globalsis mostly obsolete nowadays ever since we removed the Firefox extension code from this repository and we eliminated most globals usage. The three remaining occurrences can be replaced with explicit/* globals */comments that we already use elsewhere, which overall is also more consistent.[1] https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint-plugin-mozilla/rules/avoid-removeChild.html
[2] https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-remove.md
Fixes a part of #17928.