forked from DefinitelyTyped/DefinitelyTyped
-
Notifications
You must be signed in to change notification settings - Fork 0
Patch 2 from Flarna #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix types of luxon * fix Settings make Settings.defaultZone as readonly, change expression of Settings.now * fix static-only classes to namespace * fix unused lint rules
…nitelyTyped#22512) * Adding full Popper.js definition to Reactstrap * Reactstrap: Updating Dropdown definitions, removing Tether * Reactstrap: Adding Carousel components and test
* tabs to spaces * [node] improve typing of query.parse() * Update according to review: - Better naming UrlParsedQuery => UrlWithParsedQuery, UrlStringQuery => UrlWithStringQuery - replace Url type by UrlWithParsedQuery | UrlWithStringQuery * Re-introduce url.Url as it is used by several other modules.
…module in commonjs module option (DefinitelyTyped#22583)
…efinitelyTyped#22598) The Ports field is a map of string to _array_ of Ip/Port objects, as you can see in the docs: https://docs.docker.com/engine/api/v1.32/#operation/ContainerInspect As a result of this error type checks are not being run. e.g. Doing `container.inspect().NetworkSettings.Ports['test'][0].BadField` will compile without error, despite `BadField` to existing in the interface.
* Update insight for recent changes updates the constructor options with `pkg`, which is now preferred over `packageName` and `packageVersion`. adds `trackEvent()` method * update insight test
According to official docs the settings for setupMaster settings are just the ClusterSettings. There is an ClusterSettings interface already but setupMaster function parameters refered to incomplete and unnecessary ClusterSetupMasterSettings. I deleted the ClusterSetupMasterSettings interface and refer to the existing ClusterSettings which are correct. https://nodejs.org/docs/latest-v8.x/api/cluster.html#cluster_cluster_setupmaster_settings
The argument hash was missed in the constructor (see more in https://github.com/krasimir/navigo)
…lyTyped#22654) * Add `getRenderTarget`; deprecate `getCurrentRenderTarget()` * Update revision number; Update website; Add definition contributor Changed project website to the more common https://threejs.org
* Fix type pollution * Fix uncaught bugs of DefinitelyTyped#22267
added secureProtocol to ServerOptions
Add writableHighWaterMark/readableHighWaterMark to WriteStream/ReadStream fixed setUncaughtExceptionCaptureCallback() Add module.builtinModules change os.EOL to const add writableHighWaterMark to Duplex writableHighWaterMark and readableHighWaterMark are readonly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.