Skip to content

Conversation

@progral
Copy link
Contributor

@progral progral commented Jan 3, 2018

According to official docs the settings for setupMaster settings are just the ClusterSettings.
There is an ClusterSettings interface already but setupMaster function parameters refered to incomplete and unnecessary ClusterSetupMasterSettings. I deleted the ClusterSetupMasterSettings interface and refer to the existing ClusterSettings which are correct.

https://nodejs.org/docs/latest-v8.x/api/cluster.html#cluster_cluster_setupmaster_settings

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

According to official docs the settings for setupMaster settings are just the ClusterSettings.
There is an ClusterSettings interface already but setupMaster function parameters refered to incomplete and unnecessary ClusterSetupMasterSettings. I deleted the ClusterSetupMasterSettings interface and refer to the existing  ClusterSettings which are correct.

https://nodejs.org/docs/latest-v8.x/api/cluster.html#cluster_cluster_setupmaster_settings
@progral progral changed the title ClusterSetupMasterSettings to ClusterSettings @types/node ClusterSetupMasterSettings to ClusterSettings Jan 3, 2018
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). The Travis CI build failed labels Jan 3, 2018
@typescript-bot
Copy link
Contributor

@xipheCom The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

@mhegazy
Copy link
Contributor

mhegazy commented Jan 3, 2018

error in restify seems unrelated to this change.

@Flarna
Copy link
Contributor

Flarna commented Jan 3, 2018

@mhegazy: just created #22653 for restify issue.

@mhegazy mhegazy merged commit 0f3d1dc into DefinitelyTyped:master Jan 3, 2018
@progral progral deleted the patch-1 branch January 5, 2018 03:18
KSXGitHub pushed a commit to KSXGitHub/DefinitelyTyped that referenced this pull request May 12, 2018
According to official docs the settings for setupMaster settings are just the ClusterSettings.
There is an ClusterSettings interface already but setupMaster function parameters refered to incomplete and unnecessary ClusterSetupMasterSettings. I deleted the ClusterSetupMasterSettings interface and refer to the existing  ClusterSettings which are correct.

https://nodejs.org/docs/latest-v8.x/api/cluster.html#cluster_cluster_setupmaster_settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants