Skip to content

[mocha] Remove type overriding by NodeJS #22528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhegazy merged 2 commits into from
Jan 3, 2018
Merged

[mocha] Remove type overriding by NodeJS #22528

mhegazy merged 2 commits into from
Jan 3, 2018

Conversation

@falsandtru
Copy link
Contributor

@falsandtru falsandtru commented Dec 27, 2017

Fixes #22510

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. labels Dec 27, 2017
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 29, 2017 •
edited
Loading

@falsandtru The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added The Travis CI build failed and removed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. labels Dec 29, 2017
@falsandtru falsandtru changed the title [mocha] Fix type pollution [mocha] Remove type overriding by NodeJS Dec 29, 2017
@falsandtru
Copy link
Contributor Author

falsandtru commented Dec 29, 2017

Mocha has been used in both environments of Client(Browser) and Server(NodeJS) but current definition breaks the client environment by types of NodeJS. You must remove the reference to NodeJS.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 3, 2018

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jan 3, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jan 3, 2018

@mtraynham mind reviewing this change.

@mtraynham
Copy link
Contributor

mtraynham commented Jan 3, 2018

Seems fairly straightforward. @mhegazy, this PR does change imports from TS import/require to ES6, what is the convention for DefinitelyTyped regarding that?

@mhegazy
Copy link
Contributor

mhegazy commented Jan 3, 2018

I am not sure there is one really.

@mhegazy mhegazy merged commit f2dceb3 into DefinitelyTyped:master Jan 3, 2018
@falsandtru falsandtru deleted the mocha branch January 3, 2018 22:23
@falsandtru falsandtru mentioned this pull request Apr 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@falsandtru @typescript-bot @mhegazy @mtraynham