Skip to content

Conversation

@aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Jan 3, 2018

updates the constructor options with pkg, which is now preferred over packageName and packageVersion.
adds trackEvent() method

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/yeoman/insight#google-analytics
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

updates the constructor options with `pkg`, which is now preferred over `packageName` and `packageVersion`.
adds `trackEvent()` method
@aoberoi aoberoi requested a review from vvakame as a code owner January 3, 2018 08:49
@mhegazy mhegazy merged commit 9c0b47b into DefinitelyTyped:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants