Skip to content

[koa-webpack] Fix build by adapting test to changes in webpack-dev-mddleware #22576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jan 2, 2018
Merged

[koa-webpack] Fix build by adapting test to changes in webpack-dev-mddleware #22576

1 commit merged into from
Jan 2, 2018

Conversation

@Flarna
Copy link
Contributor

@Flarna Flarna commented Dec 29, 2017

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/webpack/webpack-dev-middleware/blob/master/breaking-changes.md
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

I got following build error:

Error in koa-webpack
Command failed: node /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js --onlyTestTsNext
Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/koa-webpack/koa-webpack-tests.ts
ERROR: 15:9  expect  TypeScript@next compile error: 
Argument of type '{ compiler: Compiler; config: Configuration; dev: { noInfo: boolean; quiet: boolean; lazy: boolea...' is not assignable to parameter of type 'Options | undefined'.
  Type '{ compiler: Compiler; config: Configuration; dev: { noInfo: boolean; quiet: boolean; lazy: boolea...' is not assignable to type 'Options'.
    Types of property 'dev' are incompatible.
      Type '{ noInfo: boolean; quiet: boolean; lazy: boolean; watchOptions: { aggregateTimeout: number; poll:...' is not assignable to type 'Options | undefined'.
        Object literal may only specify known properties, and 'noInfo' does not exist in type 'Options | undefined'.

Seems to be caused by #22267.
koa-webpack is still using webpack-dev-middleware in version 1.x but there are not 1.x typings for webpack-dev-middleware.
To fix this I removed the optional properties in test no longer present in webpack-dev-middleware as they were anyway optional.

@ghost ghost merged commit 900b042 into DefinitelyTyped:master Jan 2, 2018
@Flarna Flarna deleted the koa-webpack_fix_build branch January 2, 2018 18:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Flarna