Skip to content

Electron Webview tag support added. #22058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhegazy merged 1 commit into from
Jan 3, 2018
Merged

Electron Webview tag support added. #22058

mhegazy merged 1 commit into from
Jan 3, 2018

Conversation

@dryganets
Copy link
Contributor

@dryganets dryganets commented Dec 8, 2017

  • [ X ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ X ] Test the change in your own code. (Compile and run.)
  • [ X ] Follow the advice from the readme.
  • [ X ] Avoid common mistakes.
  • [ X ] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [ X ] Provide a URL to documentation or source code which provides context for the suggested changes: https://developer.chrome.com/apps/tags/webview
  • [ - ] Increase the version number in the header if appropriate.
  • [ - ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@dt-bot
Copy link
Member

dt-bot commented Dec 8, 2017

types/react/global.d.ts

to authors (@pspeter3 @vsiao @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @morcerf @tkrotoff @DovydasNavickas @onigoetz @richseviora @theruther4d AssureSign (account can't be detected) Microsoft (account can't be detected)). Could you review this PR?
👍 or 👎?

types/react/index.d.ts

to authors (@pspeter3 @vsiao @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @morcerf @tkrotoff @DovydasNavickas @onigoetz @richseviora @theruther4d AssureSign (account can't be detected) Microsoft (account can't be detected)). Could you review this PR?
👍 or 👎?

types/react/v15/index.d.ts

to authors (@pspeter3 @vsiao @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @morcerf @tkrotoff @DovydasNavickas @onigoetz AssureSign (account can't be detected) Microsoft (account can't be detected)). Could you review this PR?
👍 or 👎?

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 8, 2017 •
edited
Loading

@dryganets The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). The Travis CI build failed labels Dec 8, 2017
@dryganets
Copy link
Contributor Author

dryganets commented Dec 8, 2017

I guess it failed because of issues fixed here:
#22057

@dryganets dryganets force-pushed the sergeyd/react-webview branch from 5688a02 to 5ffca47 Compare December 29, 2017 22:57
@dryganets dryganets force-pushed the sergeyd/react-webview branch from 5ffca47 to 50d0f7e Compare December 29, 2017 23:31
@mhegazy mhegazy closed this Jan 3, 2018
@mhegazy mhegazy reopened this Jan 3, 2018
@mhegazy mhegazy merged commit d0db614 into DefinitelyTyped:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnnyreilly johnnyreilly Awaiting requested review from johnnyreilly johnnyreilly is a code owner

Assignees

No one assigned

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dryganets @dt-bot @typescript-bot @mhegazy