Skip to content

Conversation

@dryganets
Copy link
Contributor

  • [ x ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ x ] Test the change in your own code. (Compile and run.)
  • [ x ] Follow the advice from the readme.
  • [ x ] Avoid common mistakes.
  • [ x ] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [ - ] Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • [ - ] Increase the version number in the header if appropriate.
  • [ - ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Dec 8, 2017
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 13, 2017

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Dec 13, 2017
@aozgaa aozgaa merged commit f98225f into DefinitelyTyped:master Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants