Skip to content

Conversation

@sahlouls
Copy link
Contributor

@sahlouls sahlouls commented Jan 3, 2018

Please fill in this template.

  • [x ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x ] Test the change in your own code. (Compile and run.)
  • [ x] Follow the advice from the readme.
  • [ x] Avoid common mistakes.
  • [ x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@mhegazy mhegazy merged commit 7c58f05 into DefinitelyTyped:master Jan 3, 2018
@sahlouls sahlouls deleted the update_google.picker branch January 4, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants