-
Notifications
You must be signed in to change notification settings - Fork 30.5k
Remove chartjs in favor of chart.js #22442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Andy-MS looks like the other definitions are more updated, but also not sure if they will work as a replacement for the ones we are removing. Any way to test that? Maybe run the current test suite against the other definitions? |
|
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
paulvanbrenk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment by @FanaHOVA
|
@Andy-MS One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@Andy-MS please merge and run the depreciation script. |
|
Ran deprecation script. |
|
@Andy-MS yup, so I'm assuming old versions are unsupported now that this is merged? |
|
@FanaHOVA It should still be possible to install the old |
Fixes #12134
chartjsprovides types for the same packages aschart.js, which on NPM is namedchart.js. CC @FanaHOVA @JeroenDragtLooking at the commit history
chart.jsis much more popular thanchartjs, so I'll just assume that its types are more accurate.If this is merged, I will run
npm deprecate @types/chartjs "'@types/chartjs' is now '@types/chart.js'".