Merged
Conversation
* add e2e coverage for automatic security update screen (#5291) * add e2e coverage for automatic security update screen * removed unncessary comment. * fixing contract nickname test * readd test * fix test step * blah.
* @metamask/swaps-controller": "^6.7.1" * "@metamask/swaps-controller": "^6.7.2"
* Remove RPC URL from "Network Switched" event * Remove RPC URL from "Network Added" event * Remove block_explorer_url parameter * removed network_name from all analytics events * updated snapshot Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
Contributor
Author
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
* pairity with extension and removing the device name and the device timezone * optout metametrics * mix panel opt out * removed unnecessary comment
* Fix onboarding tutorial * Add specific prop to check for EnableAutomaticSecurityChecksModal state * Update tests
…5362) * add e2e coverage for automatic security update screen (#5291) * add e2e coverage for automatic security update screen * removed unncessary comment. * fixing contract nickname test * readd test * fix test step * Add network screen to onboarding stack * Update metametrics screen layout * Update metametrics copy * Remove old privacy policy copies * Begin handling isRPCUpdate prop in NetworkSettings * Create editable default mainnet * Fix RPC comparison * Update ETH custom network name * Enforce scroll to end on metametrics screen * e2e changes for metametrics screen * Fix rpc type warning and invalid URL crasher * Fix updating network instead of duplicating * Fix duplicate rpc networks * Begin consolidating mainnet checks * Revert "Remove old privacy policy copies" This reverts commit 029c5b6. * Revert "Update metametrics copy" This reverts commit 4bb0bd8. * Revert "Enforce scroll to end on metametrics screen" This reverts commit 8606ec7. * Revert "Update metametrics screen layout" This reverts commit 13cfe0d. * Revert opt in to use old UI. Update copy. Hide NFT banner for non default mainnet * Fix privacy policy copy * Remove send changes for another PR * Check for token contract address by chainId * add swipe up * Fix unit test and lint error Co-authored-by: Curtis David <Curtis.David7@gmail.com> Co-authored-by: CW <chris.wilcox@consensys.net>
gantunesr
approved these changes
Dec 12, 2022
Member
gantunesr
left a comment
There was a problem hiding this comment.
I only reviewed the CHANGELOG. I assume the rest of the changes have already been reviewed in other PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 5.12.1.