Skip to content

Update @metamask/swaps-controller#5331

Merged
cortisiko merged 2 commits intoMetaMask:release/5.12.0from
dan437:swaps-ctr
Dec 1, 2022
Merged

Update @metamask/swaps-controller#5331
cortisiko merged 2 commits intoMetaMask:release/5.12.0from
dan437:swaps-ctr

Conversation

@dan437
Copy link
Copy Markdown
Contributor

@dan437 dan437 commented Dec 1, 2022

Description

It changes Arbitrum and Optimism smart contract addresses to lowercase and updates a fn for checking direct wrapping.

@dan437 dan437 requested a review from a team as a code owner December 1, 2022 19:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cortisiko
Copy link
Copy Markdown
Member

Issue:

when i attempt to swap an ERC-20 token i get TypeError: undefined is not an object (evaluating 'destinationToken.toLowerCase')

see recording

@rickycodes
Copy link
Copy Markdown
Contributor

rickycodes commented Dec 1, 2022

Issue:

when i attempt to swap an ERC-20 token i get TypeError: undefined is not an object (evaluating 'destinationToken.toLowerCase')

see recording

perhaps we should consider: destinationToken.toLowerCase?.() upstream for instances where destinationToken might be undefined? /cc @dan437

@dan437 dan437 changed the title @metamask/swaps-controller": "^6.7.1" Update @metamask/swaps-controller Dec 1, 2022
Copy link
Copy Markdown
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cortisiko cortisiko added the QA Passed QA testing has been completed and passed label Dec 1, 2022
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit 1452e56 into MetaMask:release/5.12.0 Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants