Skip to content

Sanitize privacy settings before sending to Sentry#5355

Merged
sethkfman merged 4 commits intorelease/5.12.1from
513-sentry-data-scrubbing
Dec 6, 2022
Merged

Sanitize privacy settings before sending to Sentry#5355
sethkfman merged 4 commits intorelease/5.12.1from
513-sentry-data-scrubbing

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Dec 6, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Implemented the same behaviour as extension here
Also removed the Device name and Device timezone as talked here

Screenshots/Recordings

Issue

Progresses #https://github.com/metamask/mobile-planning/issues/513

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 6, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini marked this pull request as ready for review December 6, 2022 12:51
@tommasini tommasini requested a review from a team as a code owner December 6, 2022 12:51
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 6, 2022
blackdevelopa
blackdevelopa reviewed Dec 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some nitpicking

@sethkfman sethkfman added the release-5.12.1 Issue or pull request that will be included in release 5.12.1 label Dec 6, 2022
@tommasini tommasini added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 6, 2022
@sethkfman sethkfman merged commit 91ffb83 into release/5.12.1 Dec 6, 2022
@sethkfman sethkfman deleted the 513-sentry-data-scrubbing branch December 6, 2022 22:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
@sethkfman sethkfman added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board labels Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-5.12.1 Issue or pull request that will be included in release 5.12.1 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tommasini @blackdevelopa @sethkfman