add e2e coverage for automatic security update screen#5291
Merged
Conversation
Contributor
|
I was able to execute all the test scenarios on my local machine successfully. |
SamuelSalas
approved these changes
Nov 29, 2022
Contributor
SamuelSalas
left a comment
There was a problem hiding this comment.
I was able to execute all the test scenarios on my local machine successfully.
chrisleewilcox
previously requested changes
Nov 29, 2022
Contributor
chrisleewilcox
left a comment
There was a problem hiding this comment.
Not able to build.....
…to detox-appium/fix-tests-for-enable-automatic-upgrade
issue happens on main as well. Not a blocker for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR adds e2e test coverage in appium and detox for the automatic security update screen
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist