Skip to content

[Force upgrade] only fetch minimum versions if permissions enabled#5333

Merged
chrisleewilcox merged 1 commit intorelease/5.12.0from
fix/force-upgrade-call
Dec 2, 2022
Merged

[Force upgrade] only fetch minimum versions if permissions enabled#5333
chrisleewilcox merged 1 commit intorelease/5.12.0from
fix/force-upgrade-call

Conversation

@owencraston
Copy link
Copy Markdown
Contributor

@owencraston owencraston commented Dec 1, 2022 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

  • I noticed that due to an oversight I made, we were making fetch calls to Github before the user granted persmission. Luckily this was not in production.
    2. What is the improvement/solution?
  • this is a small change that checks if this permission is given before making the fetch. If not we will not fetch and return a state of Error for the useAppConfig.
  • This fix patches a bug made in this original PR

Screenshots/Recordings

Screen.Recording.2022-12-01.at.1.54.58.PM.compressed.mov

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/505

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@owencraston owencraston requested a review from a team as a code owner December 1, 2022 21:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston force-pushed the fix/force-upgrade-call branch from 5dd2978 to 6a319d2 Compare December 1, 2022 22:02
owencraston
owencraston commented Dec 1, 2022
View reviewed changes
@owencraston owencraston added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing release-5.12.1 Issue or pull request that will be included in release 5.12.1 labels Dec 1, 2022
gantunesr
gantunesr approved these changes Dec 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 1, 2022
sethkfman
sethkfman reviewed Dec 1, 2022
View reviewed changes
sethkfman
sethkfman approved these changes Dec 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owencraston owencraston added release-5.12.0 Issue or pull request that will be included in release 5.12.0 and removed release-5.12.1 Issue or pull request that will be included in release 5.12.1 labels Dec 1, 2022
@owencraston owencraston force-pushed the fix/force-upgrade-call branch from 30dda79 to 7c97233 Compare December 1, 2022 23:39
@owencraston owencraston changed the base branch from main to release/5.12.0 December 1, 2022 23:39
@owencraston owencraston force-pushed the fix/force-upgrade-call branch 2 times, most recently from e95ac4b to cd3dd5b Compare December 1, 2022 23:43
@owencraston owencraston force-pushed the fix/force-upgrade-call branch from cd3dd5b to 2ba0126 Compare December 1, 2022 23:44
chrisleewilcox
chrisleewilcox approved these changes Dec 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit b5daadf into release/5.12.0 Dec 2, 2022
@chrisleewilcox chrisleewilcox deleted the fix/force-upgrade-call branch December 2, 2022 00:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@gantunesr gantunesr gantunesr approved these changes

+1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-5.12.0 Issue or pull request that will be included in release 5.12.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@owencraston @chrisleewilcox @sethkfman @gantunesr