[Force upgrade]Trigger UpdateNeeded screen by owencraston · Pull Request #4917 · MetaMask/metamask-mobile

owencraston · 2022-08-25T21:18:17Z

Description

designs
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
in order to make users more secure we need a way to warn them if their app has a security vulnerability
this change prompts users to enable automatic checks (since we do not want to enable it by default as it will expose their IP address to github)
after this we can verify if a users app is up to date enough to remain secure
2. What is the improvement/solution?
Prompts the user to enable the automatic security checks feature
- if the user says no thanks then the we will not show the modal to update their app
if the user enables this feature then we will check if their app version is over the minimum version hosted here: https://github.com/MetaMask/metamask-mobile/tree/gh-pages
if the minimum version is higher than the current users app version we will prompt them to update
if the user clicks the the "Update to latest version" button it will take them to the app store/play store
if they click "Remind me later" then the modal will go away until they kill the app and open it again
Screenshots/Recordings

RPReplay_Final1664400891.MP4

QA

in order to QA you will need three builds, one that is 1 versions below the minimum version, one that is equal to the minimum version and one that is above the minimum version.

QA steps

download the version below the minimum version (987)
setup wallet

Path 1: Enabling automatic security checks

a prompt will appear to enable the automatic security check, click enable
on build 897 the force upgrade modal should appear
dismiss this modal by either swiping down or or clicking remind me later
continue to use the wallet and the modal should not appear
force quit the app and reopen it
the modal should appear again
clicking Update to latest version should deep link to the app store/play store
Update the app via test flight or by reinstalling the apk (989)
opening the app you should not show the force upgrade modal again

Path 1: Automatic security checks are disabled

a prompt will appear to enable the automatic security check, click No thanks
kill the app
this enable modal should not appear again
there should also be no force upgrade modal pop up at all
going to settings/privacy and scroll to the bottom
the Enable automatic security checks section should be toggled off

Non force upgrade changes

The Backup alert issue that @cortisiko mentioned below is resolved by only showing the backup alert after the user has completed/dismissed the onboarding tutorial.

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/232
Progresses #5208

Checklist

There is a related GitHub issue
Tests are included if applicable
Any added code is fully documented

github-actions · 2022-08-25T21:18:31Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/components/hooks/useMinimumVersions.ts

app/components/UI/UpdateNeeded/UpdateNeeded.tsx

app/components/hooks/useEnableAutomaticSecurityChecks.tsx

app/components/hooks/useMinimumVersions.ts

app/constants/navigation/Routes.ts

app/components/hooks/AppConfig/useAppConfig.tsx

gantunesr

LGTM

owencraston · 2022-10-03T22:39:06Z

In order to prevent the Onboarding wizard from showing up on top of my Modal I had to add the prop coverScreen={false} which changed the way the existing styles interacted with the screen. To combat this I changed the styles of the Step 5 section so that the buttons fit onto the blue modal. Now the padding is the same on both sides and we don't rely on a hardcoded DRAWER_WIDTH value

plasmacorral · 2022-11-22T21:43:54Z

Translations:

Recent updates resolve the button alignment and text obfuscation issues.

Android Samsung Galaxy A8 running Android 7.1 on a 360 by 612 Viewport
CTA is much improved on German, Greek, French, Portuguese & Russian :

On a small screen iOS device with a viewport at 320 by 548.
iPhone SE 2022 running ios 15.4

Words in CTA are much improved in German, Spanish, Greek, French, Portuguese & Russian:

The full descriptions above are scroll able on both iOS and Android.

plasmacorral · 2022-11-22T21:44:45Z

Have been unable to reproduce this observation, will monitor post launch.

These 3 issues have been resolved

- prompt user to enable this feature after onboarding - if enabled, prompt user to update their app version if they are using an unsupported version - prompt the user every time they kill the app and open it again

owencraston force-pushed the trigger-force-upgrade branch from b629aa7 to c1dad83 Compare September 15, 2022 20:31

owencraston force-pushed the trigger-force-upgrade branch 3 times, most recently from 29cf366 to d384e72 Compare September 28, 2022 19:50

owencraston marked this pull request as ready for review September 28, 2022 23:39

owencraston requested a review from a team as a code owner September 28, 2022 23:39

owencraston requested review from gantunesr and sethkfman September 28, 2022 23:40

owencraston commented Sep 28, 2022

View reviewed changes

app/components/hooks/useMinimumVersions.ts Outdated Show resolved Hide resolved

owencraston added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Code Impact - High Major code change that can have an high impact on the codebase functionality labels Sep 29, 2022

owencraston mentioned this pull request Sep 29, 2022

App config Test endpoint #5070

Merged

3 tasks

gantunesr reviewed Sep 29, 2022

View reviewed changes

owencraston force-pushed the trigger-force-upgrade branch from 6dcc819 to 6bcc3a4 Compare September 30, 2022 19:50

owencraston commented Sep 30, 2022

View reviewed changes

app/components/hooks/AppConfig/useAppConfig.tsx Outdated Show resolved Hide resolved

owencraston force-pushed the trigger-force-upgrade branch from 2427ffb to 1c5efdd Compare October 3, 2022 17:36

owencraston commented Oct 3, 2022

View reviewed changes

app/components/hooks/AppConfig/useAppConfig.tsx Outdated Show resolved Hide resolved

gantunesr reviewed Oct 3, 2022

View reviewed changes

gantunesr approved these changes Oct 3, 2022

View reviewed changes

owencraston added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 3, 2022

owencraston force-pushed the trigger-force-upgrade branch 5 times, most recently from cef7cae to eca9bb4 Compare October 4, 2022 23:21

owencraston closed this Oct 5, 2022

owencraston deleted the trigger-force-upgrade branch October 5, 2022 19:46

plasmacorral added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Nov 22, 2022

owencraston force-pushed the trigger-force-upgrade branch from 7ed0697 to ed4799c Compare November 22, 2022 22:11

owencraston and others added 16 commits November 22, 2022 14:12

Automatic security checks

fe87675

- prompt user to enable this feature after onboarding - if enabled, prompt user to update their app version if they are using an unsupported version - prompt the user every time they kill the app and open it again

fix prompting user every second

ef04593

render alert after onboarding

cbb1956

track events

1968d01

automatic security checks ananlytics

57c85a0

better meta data

ce77ec2

ternary metrics value

167d680

cleanup tests

c575685

remind me later event

1a8f347

run after interaction

1ff11ce

translations

0745325

make button grow

1b46929

cleanup scrollview

ffe33a1

make UpdateNeeded more dynamic

97d90b9

add test:

1c0e023

remove test builds

e87613d

owencraston force-pushed the trigger-force-upgrade branch from ed4799c to eac0d22 Compare November 22, 2022 22:12

use production endpoint

f1da1ee

owencraston force-pushed the trigger-force-upgrade branch from eac0d22 to f1da1ee Compare November 22, 2022 22:14

add tests back

ea0d92e

plasmacorral merged commit c80097c into main Nov 22, 2022

plasmacorral deleted the trigger-force-upgrade branch November 22, 2022 22:39

owencraston changed the title ~~Trigger UpdateNeeded screen~~ [Force upgrade]Trigger UpdateNeeded screen Dec 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Force upgrade]Trigger UpdateNeeded screen#4917

[Force upgrade]Trigger UpdateNeeded screen#4917
plasmacorral merged 18 commits intomainfrom
trigger-force-upgrade

owencraston commented Aug 25, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Aug 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gantunesr left a comment

Uh oh!

owencraston commented Oct 3, 2022

Uh oh!

plasmacorral commented Nov 22, 2022

Uh oh!

plasmacorral commented Nov 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

owencraston commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

QA

Below minimum version

Equal to minimum version

Above the minimum version

QA steps

Path 1: Enabling automatic security checks

Path 1: Automatic security checks are disabled

Non force upgrade changes

Uh oh!

github-actions bot commented Aug 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gantunesr left a comment

Choose a reason for hiding this comment

Uh oh!

owencraston commented Oct 3, 2022

Uh oh!

plasmacorral commented Nov 22, 2022

Uh oh!

plasmacorral commented Nov 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

owencraston commented Aug 25, 2022 •

edited

Loading