Skip to content

Verification missing on SentryUtils#5365

Merged
tommasini merged 1 commit intorelease/5.12.1from
fix/sentry-verification
Dec 7, 2022
Merged

Verification missing on SentryUtils#5365
tommasini merged 1 commit intorelease/5.12.1from
fix/sentry-verification

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner December 7, 2022 19:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 7, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added release-5.12.1 Issue or pull request that will be included in release 5.12.1 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Dec 7, 2022
@tommasini tommasini merged commit 58b8b79 into release/5.12.1 Dec 7, 2022
@tommasini tommasini deleted the fix/sentry-verification branch December 7, 2022 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-5.12.1 Issue or pull request that will be included in release 5.12.1 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants