Skip to content

E2e/merge new approval screen branch#5320

Merged
cortisiko merged 2 commits intorelease/5.12.0from
e2e/merge-new-approval-screen-branch
Nov 29, 2022
Merged

E2e/merge new approval screen branch#5320
cortisiko merged 2 commits intorelease/5.12.0from
e2e/merge-new-approval-screen-branch

Conversation

@cortisiko
Copy link
Copy Markdown
Member

@cortisiko cortisiko commented Nov 29, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@cortisiko
add e2e coverage for automatic security update screen (#5291)
bbf3c38 
* add e2e coverage for automatic security update screen

* removed unncessary comment.

* fixing contract nickname test

* readd test

* fix test step
@cortisiko
blah.
91ed33c
@cortisiko cortisiko requested a review from a team as a code owner November 29, 2022 19:53
sethkfman
sethkfman approved these changes Nov 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit f6f01e2 into release/5.12.0 Nov 29, 2022
@cortisiko cortisiko deleted the e2e/merge-new-approval-screen-branch branch November 29, 2022 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cortisiko @sethkfman