Skip to content

On-ramp: Add useRegions hook and fix availablePaymentMethods#5335

Merged
wachunei merged 3 commits intorelease/5.12.0from
feature/onramp-use-regions-hook
Dec 2, 2022
Merged

On-ramp: Add useRegions hook and fix availablePaymentMethods#5335
wachunei merged 3 commits intorelease/5.12.0from
feature/onramp-use-regions-hook

Conversation

@wachunei
Copy link
Copy Markdown
Member

@wachunei wachunei commented Dec 2, 2022 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PRs add a useRegions hook that captures the logic for unsupported regions reset + redirection to Region screen.
This PR also fixes the case where availablePaymentMethods remained null.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-money-movement issues related to Money Movement features release-5.12.0 Issue or pull request that will be included in release 5.12.0 release-5.12.1 Issue or pull request that will be included in release 5.12.1 labels Dec 2, 2022
@wachunei wachunei requested a review from a team as a code owner December 2, 2022 00:59
@wachunei wachunei force-pushed the feature/onramp-use-regions-hook branch from 0e81ebf to f93dcf7 Compare December 2, 2022 01:05
@wachunei wachunei changed the title On-ramp: Add useRegions hook On-ramp: Add useRegions hook and fix availablePaymentMethods Dec 2, 2022
@wachunei wachunei removed the release-5.12.1 Issue or pull request that will be included in release 5.12.1 label Dec 2, 2022
gantunesr
gantunesr approved these changes Dec 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 2, 2022
@wachunei wachunei merged commit 9c275f6 into release/5.12.0 Dec 2, 2022
@wachunei wachunei deleted the feature/onramp-use-regions-hook branch December 2, 2022 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees

No one assigned

Labels

needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-5.12.0 Issue or pull request that will be included in release 5.12.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wachunei @gantunesr