Merged
Conversation
Co-authored-by: Barry Gitarts <bgitarts@gmail.com>
…getSwapsEthToken call (#10624)
* remove transactionCategory in favor of more types * remove reference to STANDARD in stubs
* origin/develop: Position the 3dot menu in the same spot on asset screen and home screen (#10642) Move swaps constants to the shared constants directory (#10614) prefer chainId over networkId in most cases (#10594) no more node:console (#10640) fix: speedup cancellation (#10579) Setting balance to 0x0 when the original value is undefined (#10634) Hide zero balance tokens at useTokenTracker layer (#10630) Removing double click bug from delete custom network modal (#10628) remove transactionCategory in favor of more types (#10615) Ensure permission log will only store JSON-able data (#10524) Replace logic for eth swap token in fetchQuotesAndSetQuoteState with getSwapsEthToken call (#10624) add trezor HD path for ledger wallets (#10616)
Sync `master` with `develop`
The unit test npm script `test:unit:lax` is now more specific about which tests files to exclude. An `--ignore` CLI option is used to specify the files to ignore, rather than using the braces glob syntax to ignore them from the target glob itself. This makes the option easier to update going forward as we move more tests into the "strict" group, because the options are exactly the same between the two scripts. It also ensures we don't accidentally exclude other subdirectories that happen to also be named `permissions`. In trying to implement this, I stumbled at first because mocha expects the ignore pattern to be a relative path if the target is a relative path (i.e. they need to both start with `./` or neither). The script `test:unit:strict` has been updated to use a relative target pattern for consistency.
* Swaps support for local testnet * Create util method for comparison of token addresses/symbols to default swaps token * Get chainId from txMeta in _trackSwapsMetrics of transaction controller * Add comment to document purpose of getTransactionGroupRecipientAddressFilter * Use isSwapsDefaultTokenSymbol in place of repeated defaultTokenSymbol comparisons in build-quote.js
* deps - remove remotedev-server * Remove stale references from allow-scripts config Any packages that are no longer in the dependency tree have been removed from the `allow-scripts` config. Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Collaborator
Author
Builds ready [e6da76b]
Page Load Metrics (637 ± 48 ms)
|
* Remove padding on QR code image * Allow the qr code to be below the description in the whats new popup * Fix size and position of QR code in whats new notification * Add right caret to action links in whats new popup * Clean up placeImageBelowDescription logic * Fix display of whats-new-popup image * Improve spacing and sizing of whats new popup in both full screen and popup view * refactor
Collaborator
Author
Builds ready [8c46589]
Page Load Metrics (802 ± 109 ms)
|
Collaborator
Author
Builds ready [08fe3ba]
Page Load Metrics (713 ± 43 ms)
|
Collaborator
Author
Builds ready [3d7fe9b]
Page Load Metrics (585 ± 48 ms)
|
Collaborator
Author
Builds ready [08b401b]
Page Load Metrics (559 ± 52 ms)
|
tmashuang
previously approved these changes
May 4, 2021
Collaborator
Author
Builds ready [6564ad7]
Page Load Metrics (702 ± 50 ms)
|
tmashuang
approved these changes
May 5, 2021
danjm
approved these changes
May 5, 2021
ryanml
approved these changes
May 5, 2021
Collaborator
Author
Builds ready [8380cca]
Page Load Metrics (575 ± 48 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 🚀