Skip to content

Version v9.5.0 RC#10944

Merged
ryanml merged 159 commits intomasterfrom
Version-v9.5.0
May 5, 2021
Merged

Version v9.5.0 RC#10944
ryanml merged 159 commits intomasterfrom
Version-v9.5.0

Conversation

@metamaskbot
Copy link
Copy Markdown
Collaborator

📦 🚀

Gudahtt and others added 30 commits March 10, 2021 14:56
Co-authored-by: Barry Gitarts <bgitarts@gmail.com>
* remove transactionCategory in favor of more types

* remove reference to STANDARD in stubs
* origin/develop:
  Position the 3dot menu in the same spot on asset screen and home screen (#10642)
  Move swaps constants to the shared constants directory (#10614)
  prefer chainId over networkId in most cases (#10594)
  no more node:console (#10640)
  fix: speedup cancellation (#10579)
  Setting balance to 0x0 when the original value is undefined (#10634)
  Hide zero balance tokens at useTokenTracker layer (#10630)
  Removing double click bug from delete custom network modal (#10628)
  remove transactionCategory in favor of more types (#10615)
  Ensure permission log will only store JSON-able data (#10524)
  Replace logic for eth swap token in fetchQuotesAndSetQuoteState with getSwapsEthToken call (#10624)
  add trezor HD path for ledger wallets (#10616)
The unit test npm script `test:unit:lax` is now more specific about
which tests files to exclude. An `--ignore` CLI option is used to
specify the files to ignore, rather than using the braces glob syntax
to ignore them from the target glob itself.

This makes the option easier to update going forward as we move more
tests into the "strict" group, because the options are exactly the same
between the two scripts. It also ensures we don't accidentally exclude
other subdirectories that happen to also be named `permissions`.

In trying to implement this, I stumbled at first because mocha expects
the ignore pattern to be a relative path if the target is a relative
path (i.e. they need to both start with `./` or neither). The script
`test:unit:strict` has been updated to use a relative target pattern
for consistency.
* Swaps support for local testnet

* Create util method for comparison of token addresses/symbols to default swaps token

* Get chainId from txMeta in _trackSwapsMetrics of transaction controller

* Add comment to document purpose of getTransactionGroupRecipientAddressFilter

* Use isSwapsDefaultTokenSymbol in place of repeated defaultTokenSymbol comparisons in build-quote.js
* deps - remove remotedev-server

* Remove stale references from allow-scripts config

Any packages that are no longer in the dependency tree have been
removed from the `allow-scripts` config.

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [e6da76b]
Page Load Metrics (637 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44685684
domContentLoaded41581563510048
load41681663710048
domInteractive41481563510048

@ryanml ryanml dismissed a stale review via c1c9026 May 3, 2021 17:40
* Remove padding on QR code image

* Allow the qr code to be below the description in the whats new popup

* Fix size and position of QR code in whats new notification

* Add right caret to action links in whats new popup

* Clean up placeImageBelowDescription logic

* Fix display of whats-new-popup image

* Improve spacing and sizing of whats new popup in both full screen and popup view

* refactor
@ryanml ryanml force-pushed the Version-v9.5.0 branch from a409073 to 8c46589 Compare May 3, 2021 17:51
@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [8c46589]
Page Load Metrics (802 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47180793215
domContentLoaded3831214800227109
load3891215802227109
domInteractive3831214800227109

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [08fe3ba]
Page Load Metrics (713 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48796184
domContentLoaded4688347128943
load4698357138943
domInteractive4688347128943

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [3d7fe9b]
Page Load Metrics (585 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45665463
domContentLoaded39768558410048
load39868658510048
domInteractive39768558410048

tmashuang
tmashuang previously approved these changes May 4, 2021
Copy link
Copy Markdown
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [08b401b]
Page Load Metrics (559 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43695484
domContentLoaded36568255810852
load36668455910852
domInteractive36568255810852

tmashuang
tmashuang previously approved these changes May 4, 2021
@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [6564ad7]
Page Load Metrics (702 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint498764115
domContentLoaded43789570110450
load43889670210450
domInteractive43789470110450

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [8380cca]
Page Load Metrics (575 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44665473
domContentLoaded39870757410048
load40070857510048
domInteractive39870757410048

@ryanml ryanml merged commit 333206c into master May 5, 2021
@ryanml ryanml deleted the Version-v9.5.0 branch May 5, 2021 18:09
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2021
@ryanml ryanml self-assigned this May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.