Setting balance to 0x0 when the original value is undefined#10634
Merged
NiranjanaBinoy merged 2 commits intodevelopfrom Mar 12, 2021
Merged
Setting balance to 0x0 when the original value is undefined#10634NiranjanaBinoy merged 2 commits intodevelopfrom
NiranjanaBinoy merged 2 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
brad-decker
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10553
Explanation:
Issue:
TypeError: Cannot read property 'toString' of undefinederror is thrown if the balance value returned for any of the accounts is undefined.Sentry logged around 294K events from
https://costone.flare.network/ext/bc/C/rpcnetwork alone for the past 4 months(seems to start by the end of November 2020) and 2.4 K from Infura from starting around the same time.Fix: The balance value for each account is checked for undefined, if true it will be set to
0x0otherwise it will be passed to bnToHex() to convert the BigNumber to Hex.