Skip to content

Don't render faucet row in deposit modal for custom chains#10674

Merged
ryanml merged 1 commit intodevelopfrom
fix-10038
Mar 19, 2021
Merged

Don't render faucet row in deposit modal for custom chains#10674
ryanml merged 1 commit intodevelopfrom
fix-10038

Conversation

@ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 19, 2021

Fixes #10038

Follow reproduction steps laid out in issue, no longer rendering faucet links for custom chains

@ryanml ryanml requested a review from danjm March 19, 2021 02:53
@ryanml ryanml self-assigned this Mar 19, 2021
@ryanml ryanml requested a review from a team as a code owner March 19, 2021 02:53
@metamaskbot
Copy link
Collaborator

Builds ready [e6b83aa]
Page Load Metrics (647 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45785994
domContentLoaded5757946455325
load5767956475325
domInteractive5757946455325

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanml ryanml merged commit 6cfdac5 into develop Mar 19, 2021
@ryanml ryanml deleted the fix-10038 branch March 19, 2021 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insufficient number of substitutions for key "getEtherFromFaucet" with locale "en"

4 participants