Skip to content

Move swaps constants to the shared constants directory#10614

Merged
danjm merged 1 commit intodevelopfrom
swaps-constants-shared-directory
Mar 15, 2021
Merged

Move swaps constants to the shared constants directory#10614
danjm merged 1 commit intodevelopfrom
swaps-constants-shared-directory

Conversation

@danjm
Copy link
Contributor

@danjm danjm commented Mar 9, 2021

Almost all of the constants in ui/app/helpers/constants/swaps.js are used in the ui/ and app/ directories. So it makes sense that they live the the shared/constants/ directory.

@danjm danjm requested a review from a team as a code owner March 9, 2021 16:18
@danjm danjm requested a review from darkwing March 9, 2021 16:18
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Mar 9, 2021

Builds ready [5b58541]
Page Load Metrics (630 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51756073
domContentLoaded3828136289043
load3838156309043
domInteractive3818136289043

darkwing
darkwing previously approved these changes Mar 9, 2021
View reviewed changes
Gudahtt
Gudahtt previously approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danjm danjm dismissed stale reviews from Gudahtt and darkwing via 094d337 March 10, 2021 19:12
@danjm danjm force-pushed the swaps-constants-shared-directory branch from 5b58541 to 094d337 Compare March 10, 2021 19:12
Gudahtt
Gudahtt previously approved these changes Mar 10, 2021
View reviewed changes
@metamaskbot
Copy link
Collaborator

metamaskbot commented Mar 10, 2021

Builds ready [094d337]
Page Load Metrics (607 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint458359115
domContentLoaded3757316066230
load3767376076230
domInteractive3757306066230

@danjm danjm force-pushed the swaps-constants-shared-directory branch from 094d337 to 4d3af63 Compare March 11, 2021 20:14
@metamaskbot
Copy link
Collaborator

metamaskbot commented Mar 11, 2021

Builds ready [4d3af63]
Page Load Metrics (589 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint458563105
domContentLoaded3517495879144
load3537505899144
domInteractive3517485879144

@danjm danjm merged commit 153bbc6 into develop Mar 15, 2021
@danjm danjm deleted the swaps-constants-shared-directory branch March 15, 2021 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@darkwing darkwing darkwing left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danjm @metamaskbot @darkwing @Gudahtt