Skip to content

Position the 3-dot menu in the same spot on asset screen and home screen#10642

Merged
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:asset-options-jump
Mar 15, 2021
Merged

Position the 3-dot menu in the same spot on asset screen and home screen#10642
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:asset-options-jump

Conversation

@darkwing
Copy link
Contributor

Last week I implemented a standard height on the home screen header and the asset header. To further improve uniformity, we should ensure the 3-dot menu doesn't jump.

Before:

MenuJumpBefore.mp4

After:

ThreeDotAfter.mp4

@darkwing darkwing requested a review from a team as a code owner March 13, 2021 02:56
@darkwing darkwing requested a review from NiranjanaBinoy March 13, 2021 02:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darkwing darkwing merged commit 9ae8204 into MetaMask:develop Mar 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants