Skip to content

Corrected to send#10651

Merged
Gudahtt merged 4 commits intoMetaMask:developfrom
gitpurva:develop
Mar 19, 2021
Merged

Corrected to send#10651
Gudahtt merged 4 commits intoMetaMask:developfrom
gitpurva:develop

Conversation

@gitpurva
Copy link
Contributor

@gitpurva gitpurva commented Mar 15, 2021

Fixes: #10573

@gitpurva gitpurva requested a review from a team as a code owner March 15, 2021 13:08
@gitpurva gitpurva requested a review from Gudahtt March 15, 2021 13:08
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2021 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gitpurva
Copy link
Contributor Author

gitpurva commented Mar 15, 2021

I have read the CLA Document and I hereby sign the CLA.

Gudahtt
Gudahtt requested changes Mar 15, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Instead of changing the message from "Send ETH" to "Send", could you delete it entirely and use the send message in its place? We already have a localized message with the text "Send".

This would ensure other locales receive this update as well.

@Gudahtt
Copy link
Member

Gudahtt commented Mar 19, 2021

Thanks for updating the PR @gitpurva - it looks like you're still behind develop though. Could you rebase this onto develop, or merge develop into your branch?

You'll also want to remove sendETH from each other locale (that's what the lint failure is about). This can be done automatically using the script yarn verify-locales:fix

Gudahtt
Gudahtt approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Gudahtt Gudahtt merged commit fc999f9 into MetaMask:develop Mar 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not show the ethereum logo on the base currency balance for non-eth networks

2 participants

@gitpurva @Gudahtt