Merged
Conversation
Collaborator
Builds ready [adb61ce]
Page Load Metrics (593 ± 59 ms)
|
brad-decker
commented
Mar 12, 2021
adb61ce to
534a292
Compare
Collaborator
Builds ready [534a292]
Page Load Metrics (644 ± 33 ms)
|
Gudahtt
reviewed
Mar 12, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
This looks great!
Although I've changed it from network to chainId, this shouldn't result in functional changes except where user's are using custom networks with chainIds that match default chains.
I think even for those users it won't be a functional change, as we were using the chainId and mapping it back to a type (using CHAIN_ID_TO_NETWORK_ID_MAP). So it was effectively grouping by chainId already, even though it was keyed by the network identifier. Unless I missed something.
Contributor
Author
No, that's correct. This should be an entirely non-functional change. |
Collaborator
Builds ready [9b87f73]
Page Load Metrics (580 ± 45 ms)
|
Collaborator
Builds ready [fd4f5ee]
Page Load Metrics (593 ± 35 ms)
|
fd4f5ee to
dfba6c0
Compare
Collaborator
Builds ready [dfba6c0]
Page Load Metrics (594 ± 45 ms)
|
Contributor
Author
Collaborator
Builds ready [ae29cd0]
Page Load Metrics (643 ± 35 ms)
|
ae29cd0 to
a24b030
Compare
Collaborator
Builds ready [a24b030]
Page Load Metrics (608 ± 29 ms)
|
a24b030 to
fe5944e
Compare
Collaborator
Builds ready [fe5944e]
Page Load Metrics (689 ± 56 ms)
|
Contributor
Author
|
@Gudahtt could use another look at this, only thing that has changed is the migration number (and test relocation due to my other PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
As a means of more deeply understanding what the incoming transaction controller does I set out to document its methods with types and descriptions. In so doing I found a number of cases where I felt like the readability of the controller could be improved. This should be a non-functional refactor. Please take care in reading the changes to the test file to see if I have altered the desired outcomes in any functional way.
This will require a migration as I renamedincomingTxLastFetchedBlocksByNetworktoincomingTxLastFetchedBlockByChainId. Although the value is an object storing values that are blocks, eachchainIdonly has one block. Although I've changed it fromnetworktochainId, this shouldn't result in functional changes except where user's are using custom networks withchainIdsthat match default chains.Migration now included, and the case above doesn't exist because we were mapping chainId to provider type before, so custom network with chainId
0x1would have had its last fetched block stored in themainnetkey