Skip to content

Removing double click bug from delete custom network modal#10628

Merged
ryanml merged 1 commit intodevelopfrom
fix-10626
Mar 10, 2021
Merged

Removing double click bug from delete custom network modal#10628
ryanml merged 1 commit intodevelopfrom
fix-10626

Conversation

@ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 10, 2021

Fixes #10626

Manual testing steps:

  • Add a custom network
  • Open menu dropdown, click 'x' next to that custom network
  • Confirm that clicking "Cancel" in the modal dismisses the modal
  • Open menu dropdown again, clicking 'x' next to the custom network
  • Confirm that clicking "Delete" removes the custom network from the dropdown

@ryanml ryanml requested a review from a team as a code owner March 10, 2021 21:55
@ryanml ryanml requested a review from danjm March 10, 2021 21:55
brad-decker
brad-decker approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit 7aaf1c4 into develop Mar 10, 2021
@ryanml ryanml deleted the fix-10626 branch March 10, 2021 23:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danjm danjm Awaiting requested review from danjm

1 more reviewer

@brad-decker brad-decker brad-decker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete custom network modal takes two clicks to be dismissed

2 participants

@ryanml @brad-decker