[THREE] add Curve.arcLengthDivisions#25116
Merged
RyanCavanaugh merged 4 commits intoDefinitelyTyped:masterfrom Apr 19, 2018
Merged
[THREE] add Curve.arcLengthDivisions#25116RyanCavanaugh merged 4 commits intoDefinitelyTyped:masterfrom
RyanCavanaugh merged 4 commits intoDefinitelyTyped:masterfrom
Conversation
add `optionalTarget` parameter
add Curve.arcLengthDivisions
Contributor
|
@heroboy Thank you for submitting this PR! 🔔 @gyohk @florentpoujol @SereznoKot @omni360 @ivoisbelongtous @piranha771 @qszhusightp @nakakura @s093294 @Pro @efokschaner @PsychoSTS @dhritzkiv @apurvaojas - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
efokschaner
approved these changes
Apr 19, 2018
Contributor
efokschaner
left a comment
There was a problem hiding this comment.
Approved but it would be nice if you fixed the whitespace.
types/three/three-core.d.ts
Outdated
| */ | ||
| export class Curve<T extends Vector> { | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Indentation is off on this line.
Contributor
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
efokschaner
approved these changes
Apr 19, 2018
cmaddalozzo
pushed a commit
to cmaddalozzo/DefinitelyTyped
that referenced
this pull request
Apr 20, 2018
* 'master' of github.com:DefinitelyTyped/DefinitelyTyped: (181 commits) [Joi] - add schema option to .when (DefinitelyTyped#25136) @types/mapbox-gl maxDuration property in FlyToOptions (DefinitelyTyped#25088) Glue - Fix to plugins (DefinitelyTyped#25141) add addEventListener to eventsource (DefinitelyTyped#25125) Adding more siblings to Red interface in node-red (DefinitelyTyped#25013) [knex] Add QueryBuilder to knex.raw bindings (DefinitelyTyped#25100) react: change default type value of snapshot to any (DefinitelyTyped#24987) added typings for mapbox-gl-leaflet (DefinitelyTyped#25120) React animate on scroll (DefinitelyTyped#25131) Fixed AccountResponse's signers' object (DefinitelyTyped#25095) React-navigation onTransition event pass props (DefinitelyTyped#25121) dotenv-safe 5.0 (DefinitelyTyped#25124) change member types from variable to method (DefinitelyTyped#25097) Updating react-native-drawer definitions from 2.3 to 2.5 (DefinitelyTyped#25118) Added the statement of ActiveSelection (DefinitelyTyped#25084) [THREE] add Curve.arcLengthDivisions (DefinitelyTyped#25116) [atom] Support version v1.26. (DefinitelyTyped#25111) [adone] refactoring, additions (DefinitelyTyped#25114) (react-native-modalbox) Remove ViewProperties from main props (DefinitelyTyped#25128) added typings for npm package ng-tags-input (DefinitelyTyped#24946) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://threejs.org/docs/index.html#api/extras/core/Curve.arcLengthDivisions