Skip to content

React animate on scroll#25131

Merged
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
ralbuque:react-animate-on-scroll
Apr 19, 2018
Merged

React animate on scroll#25131
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
ralbuque:react-animate-on-scroll

Conversation

@ralbuque
Copy link
Copy Markdown

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback labels Apr 19, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 19, 2018

@ralbuque Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@RyanCavanaugh RyanCavanaugh merged commit 4f374d2 into DefinitelyTyped:master Apr 19, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

cmaddalozzo pushed a commit to cmaddalozzo/DefinitelyTyped that referenced this pull request Apr 20, 2018
* 'master' of github.com:DefinitelyTyped/DefinitelyTyped: (181 commits)
  [Joi] - add schema option to .when (DefinitelyTyped#25136)
  @types/mapbox-gl maxDuration property in FlyToOptions (DefinitelyTyped#25088)
  Glue - Fix to plugins (DefinitelyTyped#25141)
  add addEventListener to eventsource (DefinitelyTyped#25125)
  Adding more siblings to Red interface in node-red (DefinitelyTyped#25013)
  [knex] Add QueryBuilder to knex.raw bindings (DefinitelyTyped#25100)
  react: change default type value of snapshot to any (DefinitelyTyped#24987)
  added typings for mapbox-gl-leaflet (DefinitelyTyped#25120)
  React animate on scroll (DefinitelyTyped#25131)
  Fixed AccountResponse's signers' object (DefinitelyTyped#25095)
  React-navigation onTransition event pass props (DefinitelyTyped#25121)
  dotenv-safe 5.0 (DefinitelyTyped#25124)
  change member types from variable to method (DefinitelyTyped#25097)
  Updating react-native-drawer definitions from 2.3 to 2.5 (DefinitelyTyped#25118)
  Added the statement of ActiveSelection (DefinitelyTyped#25084)
  [THREE] add Curve.arcLengthDivisions (DefinitelyTyped#25116)
  [atom] Support version v1.26. (DefinitelyTyped#25111)
  [adone] refactoring, additions (DefinitelyTyped#25114)
  (react-native-modalbox) Remove ViewProperties from main props (DefinitelyTyped#25128)
  added typings for npm package ng-tags-input (DefinitelyTyped#24946)
  ...
@ralbuque ralbuque deleted the react-animate-on-scroll branch April 20, 2018 11:22
@ralbuque
Copy link
Copy Markdown
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants