Skip to content

[atom] Support version v1.26.#25111

Merged
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
GlenCFL:v1.26
Apr 19, 2018
Merged

[atom] Support version v1.26.#25111
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
GlenCFL:v1.26

Conversation

@GlenCFL
Copy link
Copy Markdown
Contributor

@GlenCFL GlenCFL commented Apr 19, 2018 •
edited
Loading

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes:
    Atom v1.26 Release Page
    Atom v1.26 Blog Post
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

Atom v1.26 has no changes to the API whatsoever. With no changes, we're really just following up on a few things here:

  1. Pull request [atom] Updates to AC+ types #24967, which kept a type around in order to prevent breakage within a patch version.
  2. The deprecation of a property, now that we have clarification from the Atom team here.

@typescript-bot typescript-bot added Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Apr 19, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 19, 2018 •
edited
Loading

@GlenCFL Thank you for submitting this PR!

🔔 @smhxx @lierdakil - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 19, 2018 •
edited
Loading

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

lierdakil
lierdakil approved these changes Apr 19, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@lierdakil lierdakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lierdakil
Copy link
Copy Markdown
Contributor

lierdakil commented Apr 19, 2018

Actually, I found one thing missing: atom/atom#16661 -- this apparently made it into 1.26, but there's zero documentation except what's in that PR description (JSDoc wasn't touched at all in that PR). Don't want to block over it though.

@GlenCFL
Copy link
Copy Markdown
Contributor Author

GlenCFL commented Apr 19, 2018

I don't have a problem tacking that on. The only issue would be, as you mentioned, there not being any descriptions for those four properties.

@lierdakil
Copy link
Copy Markdown
Contributor

lierdakil commented Apr 19, 2018

Well, I can tell you looking at the specs that all those properties should have type string[], and strings are actually commands. That's pretty much it. And I think we can always add docstrings later when/if Atom team writes something.

... also, while at it, looking at ContextMenuOptions, I think that's a bit under-typed. Should probably be something like

type ContextMenuOptions = ContextMenuOptionsWithoutType | { type: "separator" }

@GlenCFL
Copy link
Copy Markdown
Contributor Author

GlenCFL commented Apr 19, 2018

Just used some placeholder descriptions that will hopefully be replaced with official ones in the future.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Awaiting reviewer feedback labels Apr 19, 2018
@lierdakil
Copy link
Copy Markdown
Contributor

lierdakil commented Apr 19, 2018

👍

@RyanCavanaugh RyanCavanaugh merged commit a146d14 into DefinitelyTyped:master Apr 19, 2018
@GlenCFL GlenCFL deleted the v1.26 branch April 19, 2018 20:48
cmaddalozzo pushed a commit to cmaddalozzo/DefinitelyTyped that referenced this pull request Apr 20, 2018
Merge branch 'master' of github.com:DefinitelyTyped/DefinitelyTyped
1c06af9 
* 'master' of github.com:DefinitelyTyped/DefinitelyTyped: (181 commits)
  [Joi] - add schema option to .when (DefinitelyTyped#25136)
  @types/mapbox-gl maxDuration property in FlyToOptions (DefinitelyTyped#25088)
  Glue - Fix to plugins (DefinitelyTyped#25141)
  add addEventListener to eventsource (DefinitelyTyped#25125)
  Adding more siblings to Red interface in node-red (DefinitelyTyped#25013)
  [knex] Add QueryBuilder to knex.raw bindings (DefinitelyTyped#25100)
  react: change default type value of snapshot to any (DefinitelyTyped#24987)
  added typings for mapbox-gl-leaflet (DefinitelyTyped#25120)
  React animate on scroll (DefinitelyTyped#25131)
  Fixed AccountResponse's signers' object (DefinitelyTyped#25095)
  React-navigation onTransition event pass props (DefinitelyTyped#25121)
  dotenv-safe 5.0 (DefinitelyTyped#25124)
  change member types from variable to method (DefinitelyTyped#25097)
  Updating react-native-drawer definitions from 2.3 to 2.5 (DefinitelyTyped#25118)
  Added the statement of ActiveSelection (DefinitelyTyped#25084)
  [THREE] add Curve.arcLengthDivisions (DefinitelyTyped#25116)
  [atom] Support version v1.26. (DefinitelyTyped#25111)
  [adone] refactoring, additions (DefinitelyTyped#25114)
  (react-native-modalbox) Remove ViewProperties from main props (DefinitelyTyped#25128)
  added typings for npm package ng-tags-input (DefinitelyTyped#24946)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@smhxx smhxx smhxx approved these changes

@lierdakil lierdakil lierdakil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GlenCFL @typescript-bot @lierdakil @smhxx @RyanCavanaugh