[atom] Updates to AC+ types#24967
Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom Apr 13, 2018
Merged
Conversation
Contributor
|
@lierdakil Thank you for submitting this PR! 🔔 @GlenCFL @smhxx - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
GlenCFL
approved these changes
Apr 13, 2018
Contributor
GlenCFL
left a comment
There was a problem hiding this comment.
Looks good. Thanks for both PRs.
I'll make sure that Suggestion is removed with v1.26.
Contributor
|
A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
descriptionMarkdown: https://github.com/atom/autocomplete-plus/blob/d6558d43657f29b349ce04cd1e9aa6b06f2eedea/lib/suggestion-list-element.js#L137getSuggestionDetailsOnSelect: https://github.com/atom/autocomplete-plus/wiki/Provider-APItslint.jsoncontaining{ "extends": "dtslint/dt.json" }.Other changes are because
Suggestiontype is extremely unwieldly and seemingly pointless. I'm leaving a stub in place for the purpose of compatibility, but we better remove it once 1.26 hits.