added typings for npm package ng-tags-input#24946
added typings for npm package ng-tags-input#24946RyanCavanaugh merged 5 commits intoDefinitelyTyped:masterfrom
Conversation
|
@GiorgosPap Thank you for submitting this PR! Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
|
@GiorgosPap The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
@RyanCavanaugh Should I fix the Travis CI issues or should I wait for the reviewer's feedback? |
|
@GiorgosPap fix the CI-related issues first please; in general people aren't going to review code that they know won't be checked in in its current state |
|
@GiorgosPap The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
@GiorgosPap I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
|
🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ Congratulations on your first DefinitelyTyped contribution! 🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ |
* 'master' of github.com:DefinitelyTyped/DefinitelyTyped: (181 commits) [Joi] - add schema option to .when (DefinitelyTyped#25136) @types/mapbox-gl maxDuration property in FlyToOptions (DefinitelyTyped#25088) Glue - Fix to plugins (DefinitelyTyped#25141) add addEventListener to eventsource (DefinitelyTyped#25125) Adding more siblings to Red interface in node-red (DefinitelyTyped#25013) [knex] Add QueryBuilder to knex.raw bindings (DefinitelyTyped#25100) react: change default type value of snapshot to any (DefinitelyTyped#24987) added typings for mapbox-gl-leaflet (DefinitelyTyped#25120) React animate on scroll (DefinitelyTyped#25131) Fixed AccountResponse's signers' object (DefinitelyTyped#25095) React-navigation onTransition event pass props (DefinitelyTyped#25121) dotenv-safe 5.0 (DefinitelyTyped#25124) change member types from variable to method (DefinitelyTyped#25097) Updating react-native-drawer definitions from 2.3 to 2.5 (DefinitelyTyped#25118) Added the statement of ActiveSelection (DefinitelyTyped#25084) [THREE] add Curve.arcLengthDivisions (DefinitelyTyped#25116) [atom] Support version v1.26. (DefinitelyTyped#25111) [adone] refactoring, additions (DefinitelyTyped#25114) (react-native-modalbox) Remove ViewProperties from main props (DefinitelyTyped#25128) added typings for npm package ng-tags-input (DefinitelyTyped#24946) ...
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.