Added the statement of ActiveSelection#25084
Added the statement of ActiveSelection#25084RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
A declaration about ActiveSelection has been added after Group.
|
A declaration about ActiveSelection has been added after Group. |
1 similar comment
|
A declaration about ActiveSelection has been added after Group. |
|
@ougunbu Thank you for submitting this PR! 🔔 @oklemencic @joewashear007 @mrand01 @NotWoods @bmartinson - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
NotWoods
left a comment
There was a problem hiding this comment.
Please provide a URL to documentation or source code which provides context for the ActiveSelection changes. Also use more precise types than any if possible.
types/fabric/fabric-impl.d.ts
Outdated
| * @param objects ActiveSelection objects | ||
| * @param [options] Options object | ||
| */ | ||
| constructor(items?: any[], options?: IObjectOptions); |
There was a problem hiding this comment.
Is there a more precise type than any?
There was a problem hiding this comment.
changed any[] to Object[]
types/fabric/fabric-impl.d.ts
Outdated
| * @param object Object to create a group from | ||
| * @param [callback] Callback to invoke when an ActiveSelection instance is created | ||
| */ | ||
| static fromObject(object: any, callback: (activeSelection: ActiveSelection) => any): void; |
There was a problem hiding this comment.
Is there a more precise type than any for object?
There was a problem hiding this comment.
changed any to Group
types/fabric/fabric-impl.d.ts
Outdated
| * @param object Object to create a group from | ||
| * @param [callback] Callback to invoke when an ActiveSelection instance is created | ||
| */ | ||
| static fromObject(object: any, callback: (activeSelection: ActiveSelection) => any): void; |
There was a problem hiding this comment.
If fromObject doesn't use the return value of callback, change it to (activeSelection: ActiveSelection) => void. Otherwise, is there a more precise type?
There was a problem hiding this comment.
As you say,changed it to (activeSelection: ActiveSelection) => void
There was a problem hiding this comment.
After the change of type, I have tested it locally. There is no problem.
Do I need to submit the code once more?
There was a problem hiding this comment.
Please push your new changes! After that you should be all set 😀.
|
@ougunbu One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you! |
Line number 1723: changed any[] to Object[] Line number 1751: changed any to Group Line number 1751: changed "(activeSelection: ActiveSelection) => any" to "(activeSelection: ActiveSelection) => void"
|
The code has been revised. |
|
🔔 @NotWoods - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ Congratulations on your first DefinitelyTyped contribution! 🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ |
* 'master' of github.com:DefinitelyTyped/DefinitelyTyped: (181 commits) [Joi] - add schema option to .when (DefinitelyTyped#25136) @types/mapbox-gl maxDuration property in FlyToOptions (DefinitelyTyped#25088) Glue - Fix to plugins (DefinitelyTyped#25141) add addEventListener to eventsource (DefinitelyTyped#25125) Adding more siblings to Red interface in node-red (DefinitelyTyped#25013) [knex] Add QueryBuilder to knex.raw bindings (DefinitelyTyped#25100) react: change default type value of snapshot to any (DefinitelyTyped#24987) added typings for mapbox-gl-leaflet (DefinitelyTyped#25120) React animate on scroll (DefinitelyTyped#25131) Fixed AccountResponse's signers' object (DefinitelyTyped#25095) React-navigation onTransition event pass props (DefinitelyTyped#25121) dotenv-safe 5.0 (DefinitelyTyped#25124) change member types from variable to method (DefinitelyTyped#25097) Updating react-native-drawer definitions from 2.3 to 2.5 (DefinitelyTyped#25118) Added the statement of ActiveSelection (DefinitelyTyped#25084) [THREE] add Curve.arcLengthDivisions (DefinitelyTyped#25116) [atom] Support version v1.26. (DefinitelyTyped#25111) [adone] refactoring, additions (DefinitelyTyped#25114) (react-native-modalbox) Remove ViewProperties from main props (DefinitelyTyped#25128) added typings for npm package ng-tags-input (DefinitelyTyped#24946) ...
A declaration about ActiveSelection has been added after Group.
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.If removing a declaration:
notNeededPackages.json.