Skip to content

Added the statement of ActiveSelection#25084

Merged
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
ougunbu:patch-2
Apr 19, 2018
Merged

Added the statement of ActiveSelection#25084
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
ougunbu:patch-2

Conversation

@ougunbu
Copy link
Copy Markdown
Contributor

@ougunbu ougunbu commented Apr 18, 2018

A declaration about ActiveSelection has been added after Group.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

A declaration about ActiveSelection has been added after Group.
@ougunbu
Copy link
Copy Markdown
Contributor Author

ougunbu commented Apr 18, 2018

A declaration about ActiveSelection has been added after Group.

1 similar comment
@ougunbu
Copy link
Copy Markdown
Contributor Author

ougunbu commented Apr 18, 2018

A declaration about ActiveSelection has been added after Group.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 18, 2018

@ougunbu Thank you for submitting this PR!

🔔 @oklemencic @joewashear007 @mrand01 @NotWoods @bmartinson - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Copy Markdown
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a URL to documentation or source code which provides context for the ActiveSelection changes. Also use more precise types than any if possible.

* @param objects ActiveSelection objects
* @param [options] Options object
*/
constructor(items?: any[], options?: IObjectOptions);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more precise type than any?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed any[] to Object[]

* @param object Object to create a group from
* @param [callback] Callback to invoke when an ActiveSelection instance is created
*/
static fromObject(object: any, callback: (activeSelection: ActiveSelection) => any): void;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more precise type than any for object?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed any to Group

* @param object Object to create a group from
* @param [callback] Callback to invoke when an ActiveSelection instance is created
*/
static fromObject(object: any, callback: (activeSelection: ActiveSelection) => any): void;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If fromObject doesn't use the return value of callback, change it to (activeSelection: ActiveSelection) => void. Otherwise, is there a more precise type?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you say,changed it to (activeSelection: ActiveSelection) => void

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the change of type, I have tested it locally. There is no problem.
Do I need to submit the code once more?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please push your new changes! After that you should be all set 😀.

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback labels Apr 18, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

@ougunbu One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Apr 18, 2018
Line number 1723: changed any[] to Object[]
Line number 1751: changed any to Group
Line number 1751: changed "(activeSelection: ActiveSelection) => any" to "(activeSelection: ActiveSelection) => void"
@ougunbu
Copy link
Copy Markdown
Contributor Author

ougunbu commented Apr 19, 2018

The code has been revised.

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @NotWoods - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express labels Apr 19, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit ac1a16b into DefinitelyTyped:master Apr 19, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

cmaddalozzo pushed a commit to cmaddalozzo/DefinitelyTyped that referenced this pull request Apr 20, 2018
* 'master' of github.com:DefinitelyTyped/DefinitelyTyped: (181 commits)
  [Joi] - add schema option to .when (DefinitelyTyped#25136)
  @types/mapbox-gl maxDuration property in FlyToOptions (DefinitelyTyped#25088)
  Glue - Fix to plugins (DefinitelyTyped#25141)
  add addEventListener to eventsource (DefinitelyTyped#25125)
  Adding more siblings to Red interface in node-red (DefinitelyTyped#25013)
  [knex] Add QueryBuilder to knex.raw bindings (DefinitelyTyped#25100)
  react: change default type value of snapshot to any (DefinitelyTyped#24987)
  added typings for mapbox-gl-leaflet (DefinitelyTyped#25120)
  React animate on scroll (DefinitelyTyped#25131)
  Fixed AccountResponse's signers' object (DefinitelyTyped#25095)
  React-navigation onTransition event pass props (DefinitelyTyped#25121)
  dotenv-safe 5.0 (DefinitelyTyped#25124)
  change member types from variable to method (DefinitelyTyped#25097)
  Updating react-native-drawer definitions from 2.3 to 2.5 (DefinitelyTyped#25118)
  Added the statement of ActiveSelection (DefinitelyTyped#25084)
  [THREE] add Curve.arcLengthDivisions (DefinitelyTyped#25116)
  [atom] Support version v1.26. (DefinitelyTyped#25111)
  [adone] refactoring, additions (DefinitelyTyped#25114)
  (react-native-modalbox) Remove ViewProperties from main props (DefinitelyTyped#25128)
  added typings for npm package ng-tags-input (DefinitelyTyped#24946)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Revision needed This PR needs code changes before it can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants