Skip to content

[knex] Add QueryBuilder to knex.raw bindings#25100

Merged
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
edorivai:master
Apr 19, 2018
Merged

[knex] Add QueryBuilder to knex.raw bindings#25100
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
edorivai:master

Conversation

@edorivai
Copy link
Copy Markdown
Contributor

@edorivai edorivai commented Apr 18, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Adding upsert type capability knex/knex#54 (comment)
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 18, 2018 •
edited
Loading

@edorivai Thank you for submitting this PR!

🔔 @tkqubo @baronfel @MeLlamoPablo @mastermatt @micksatana @shreyjain1994 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Apr 19, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 19, 2018

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit 57f3c17 into DefinitelyTyped:master Apr 19, 2018
cmaddalozzo pushed a commit to cmaddalozzo/DefinitelyTyped that referenced this pull request Apr 20, 2018
Merge branch 'master' of github.com:DefinitelyTyped/DefinitelyTyped
1c06af9 
* 'master' of github.com:DefinitelyTyped/DefinitelyTyped: (181 commits)
  [Joi] - add schema option to .when (DefinitelyTyped#25136)
  @types/mapbox-gl maxDuration property in FlyToOptions (DefinitelyTyped#25088)
  Glue - Fix to plugins (DefinitelyTyped#25141)
  add addEventListener to eventsource (DefinitelyTyped#25125)
  Adding more siblings to Red interface in node-red (DefinitelyTyped#25013)
  [knex] Add QueryBuilder to knex.raw bindings (DefinitelyTyped#25100)
  react: change default type value of snapshot to any (DefinitelyTyped#24987)
  added typings for mapbox-gl-leaflet (DefinitelyTyped#25120)
  React animate on scroll (DefinitelyTyped#25131)
  Fixed AccountResponse's signers' object (DefinitelyTyped#25095)
  React-navigation onTransition event pass props (DefinitelyTyped#25121)
  dotenv-safe 5.0 (DefinitelyTyped#25124)
  change member types from variable to method (DefinitelyTyped#25097)
  Updating react-native-drawer definitions from 2.3 to 2.5 (DefinitelyTyped#25118)
  Added the statement of ActiveSelection (DefinitelyTyped#25084)
  [THREE] add Curve.arcLengthDivisions (DefinitelyTyped#25116)
  [atom] Support version v1.26. (DefinitelyTyped#25111)
  [adone] refactoring, additions (DefinitelyTyped#25114)
  (react-native-modalbox) Remove ViewProperties from main props (DefinitelyTyped#25128)
  added typings for npm package ng-tags-input (DefinitelyTyped#24946)
  ...
@melvin1992
Copy link
Copy Markdown

melvin1992 commented Apr 27, 2018

Can we also include some values that is not supported in the list of value like enum? Since we update the bindings for Raw from object to ValueMap and there are few types which are not included.

@edorivai
Copy link
Copy Markdown
Contributor Author

edorivai commented Apr 28, 2018

@melvin1992, just make a PR. I changed it to my best understanding of the docs, but I have surely missed some edge cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MeLlamoPablo MeLlamoPablo MeLlamoPablo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@edorivai @typescript-bot @melvin1992 @MeLlamoPablo @RyanCavanaugh