Upcoming Events file sync with WPCOM.#6059
Merged
dereksmart merged 7 commits intomasterfrom Jan 10, 2017
Merged
Conversation
props @taggon The widget doesn't show the dates in the blog's timezone. But the `icalendar_render_events` function, which is used for generating output, doesn't provide option for blog's timezone. So I make the widget handle blog's timezone, apply it to the dates and render the output. See: https://github.com/Automattic/customization/issues/111 See: https://[private link] Merges r139672-wpcom.
Merges r144867-wpcom.
Conflicts: modules/widgets/upcoming-events.php
We had never actually shipped the file, so it went unnoticed for a while.
6 tasks
dereksmart
requested changes
Jan 9, 2017
Contributor
dereksmart
left a comment
There was a problem hiding this comment.
The shorcode is throwing notices when adding events that don't have descriptions or locations:
Notice: Undefined index: LOCATION in /home/dereksma/public_html/wp-content/plugins/jetpack/_inc/lib/icalendar-reader.php on line 749
Notice: Undefined index: DESCRIPTION in /home/dereksma/public_html/wp-content/plugins/jetpack/_inc/lib/icalendar-reader.php on line 752
| } | ||
| } | ||
|
|
||
| add_action( 'plugins_loaded', array( 'Upcoming_Events_Shortcode', 'init' ), 100 ); |
Contributor
There was a problem hiding this comment.
I had to bump this to priority 101 to get it to register.
Contributor
|
Widget changes look good 👍 |
Depending on some datasets, they may not be available.
Contributor
Author
|
@dereksmart I think I've got what you need, can you give it a skim and confirm? |
Contributor
|
@georgestephanis changes look great, thanks! This is good to ship |
dereksmart
approved these changes
Jan 10, 2017
dereksmart
added a commit
that referenced
this pull request
Jan 10, 2017
Upcoming Events file sync with WPCOM.
Contributor
|
Merged to 4.5 78ee704 |
|
We've been seeing some issues on WPCOM with the Upcoming Events widget around daylight savings boundaries. I'm not sure if those issues were pre-existing, but it's possible the issue will come up in Jetpack with this sync. It's a subtle bug that only happens as we approach a daylight savings boundary, when events are scheduled after that boundary. Details: p2UL9c-2Zq-p2 |
dereksmart
pushed a commit
that referenced
this pull request
Jan 17, 2017
CHangelog: add #5457 Changelog: add #5487 Changelog: add #5708 Changelog: add #5879 Changelog: add #5932 Changelog: add #5963 Changelog: add #5968 Changelog: add #5996 Changelog: add #5998 Changelog: add #5999 Changelog: add #6012 Changelog: add #6013 Changelog: add #6014 Changelog: add #6015 Changelog: add #6023 Changelog: add #6024 Changelog: add #6030 Changelog: add #5465 CHangelog: add #6063 Changelog: add #6025 Changelog: add #5974 Changelog: add #6059 Changelog: add #6046 Changelog: add #5418 Changelog: move things around and add missing information. Changelog: add #5565 Changelog: add #6087 Changelog: add #6095
dereksmart
pushed a commit
that referenced
this pull request
Jan 17, 2017
Changelog: add #5867 Changelog: add #5874 Changelog: add #5905 Changelog: add #5906 Changelog: add #5931 Changelog: add #5933 Changelog: add #5934 Bring over 4.4.2 changelog from branch-4.4 @see 18012a3 Changelog: add #5976, #5978, #5983 Changelog: add #5917 Changelog: add #5832 Changelog: add 4.4.2 release post link. CHangelog: add #5457 Changelog: add #5487 Changelog: add #5708 Changelog: add #5879 Changelog: add #5932 Changelog: add #5963 Changelog: add #5968 Changelog: add #5996 Changelog: add #5998 Changelog: add #5999 Changelog: add #6012 Changelog: add #6013 Changelog: add #6014 Changelog: add #6015 Changelog: add #6023 Changelog: add #6024 Changelog: add #6030 Changelog: add #5465 CHangelog: add #6063 Changelog: add #6025 Changelog: add #5974 Changelog: add #6059 Changelog: add #6046 Changelog: add #5418 Changelog: move things around and add missing information. Changelog: add #5565 Changelog: add #6087 Changelog: add #6095 Readme: add @tyxla to the list of contributors. Improved changelog for your readability and enjoyment updated the release date finalizing the changelog with a few more edits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Syncs up files regarding the Upcoming Events widget and shortcode from WPCOM including some changes by @sirbrillig regarding timezones.
As this is only now finally shipping, shouldn't need a changelog entry.