Skip to content

Widgets: various fixes in Customizer and Widgets admin screen#5905

Merged
dereksmart merged 7 commits intomasterfrom
fix/widgets-customizer
Dec 20, 2016
Merged

Widgets: various fixes in Customizer and Widgets admin screen#5905
dereksmart merged 7 commits intomasterfrom
fix/widgets-customizer

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Dec 15, 2016

Changes proposed in this Pull Request:

View of the widget in Customizer.
captura de pantalla 2016-12-15 a las 14 33 43

View of the widget in Widgets admin screen in mobile screen size. The layout at this size in Customizer is similar.
captura de pantalla 2016-12-15 a las 14 33 51

Testing instructions:

  • add these widgets:
Subscriptions
Authors
Gallery
Milestone
WordPress Posts
  • make sure they don't extend beyond the Customizer width.
  • the first time you add a Milestone widget to Customizer, make sure it's stylized in the preview
  • the Milestone widget control in Customizer should be stylized
  • add WordPress Posts in Customizer and make sure there are no PHP warnings regarding title and url array indexes

Proposed changelog entry for your changes:

Fix: adding a WordPress Posts widget in Customizer no longer displays PHP warnings
Fix: the Subscriptions and Authors widgets no longer extend beyond the Customizer width

…when it's first added and previewed in Customizer
…stomizer.

Previously the styles were broken in mobile screen sizes, this patch fixes it.
It introduces distinctive separated labels for Date and Time in mobile screen sizes.
Balances height of elements and aligns them in admin and Customizer.
Increase number of visible rows in message text box.
@eliorivero eliorivero added [Feature] Extra Sidebar Widgets [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Dec 15, 2016
@eliorivero eliorivero added this to the 4.5 milestone Dec 15, 2016
@eliorivero eliorivero self-assigned this Dec 15, 2016
@dereksmart
Copy link
Copy Markdown
Contributor

  • add these widgets:
  • make sure they don't extend beyond the Customizer width.
  • the first time you add a Milestone widget to Customizer, make sure it's stylized in the preview
    the Milestone widget control in Customizer should be stylized
  • add WordPress Posts in Customizer and make sure there are no PHP warnings regarding title and url array indexes

Tests well

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 15, 2016
@eliorivero eliorivero force-pushed the fix/widgets-customizer branch 3 times, most recently from 7c52688 to 900d133 Compare December 16, 2016 14:16
@eliorivero eliorivero force-pushed the fix/widgets-customizer branch from 900d133 to b632308 Compare December 16, 2016 14:19
@dereksmart dereksmart merged commit 1d0f64f into master Dec 20, 2016
@dereksmart
Copy link
Copy Markdown
Contributor

branch 4.5 6a51b58

@dereksmart dereksmart deleted the fix/widgets-customizer branch December 20, 2016 23:11
jeherve added a commit that referenced this pull request Dec 21, 2016
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934

Bring over 4.4.2 changelog from branch-4.4

@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832

Changelog: add 4.4.2 release post link.

CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095

Readme: add @tyxla to the list of contributors.

Improved changelog for your readability and enjoyment

updated the release date

finalizing the changelog with a few more edits
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets

Projects

None yet

5 participants