SAL: Move icon logic to Jetpack base, leverage core site icon option consistently#6025
Merged
dereksmart merged 3 commits intomasterfrom Jan 11, 2017
Merged
SAL: Move icon logic to Jetpack base, leverage core site icon option consistently#6025dereksmart merged 3 commits intomasterfrom
dereksmart merged 3 commits intomasterfrom
Conversation
Contributor
|
Tests well, thanks aduth |
Member
Author
|
Pushed 803e119 to improve logic in omitting possible falsey icons. Reference:
|
Contributor
|
👌 latest change. |
Contributor
dereksmart
pushed a commit
that referenced
this pull request
Jan 17, 2017
CHangelog: add #5457 Changelog: add #5487 Changelog: add #5708 Changelog: add #5879 Changelog: add #5932 Changelog: add #5963 Changelog: add #5968 Changelog: add #5996 Changelog: add #5998 Changelog: add #5999 Changelog: add #6012 Changelog: add #6013 Changelog: add #6014 Changelog: add #6015 Changelog: add #6023 Changelog: add #6024 Changelog: add #6030 Changelog: add #5465 CHangelog: add #6063 Changelog: add #6025 Changelog: add #5974 Changelog: add #6059 Changelog: add #6046 Changelog: add #5418 Changelog: move things around and add missing information. Changelog: add #5565 Changelog: add #6087 Changelog: add #6095
dereksmart
pushed a commit
that referenced
this pull request
Jan 17, 2017
Changelog: add #5867 Changelog: add #5874 Changelog: add #5905 Changelog: add #5906 Changelog: add #5931 Changelog: add #5933 Changelog: add #5934 Bring over 4.4.2 changelog from branch-4.4 @see 18012a3 Changelog: add #5976, #5978, #5983 Changelog: add #5917 Changelog: add #5832 Changelog: add 4.4.2 release post link. CHangelog: add #5457 Changelog: add #5487 Changelog: add #5708 Changelog: add #5879 Changelog: add #5932 Changelog: add #5963 Changelog: add #5968 Changelog: add #5996 Changelog: add #5998 Changelog: add #5999 Changelog: add #6012 Changelog: add #6013 Changelog: add #6014 Changelog: add #6015 Changelog: add #6023 Changelog: add #6024 Changelog: add #6030 Changelog: add #5465 CHangelog: add #6063 Changelog: add #6025 Changelog: add #5974 Changelog: add #6059 Changelog: add #6046 Changelog: add #5418 Changelog: move things around and add missing information. Changelog: add #5565 Changelog: add #6087 Changelog: add #6095 Readme: add @tyxla to the list of contributors. Improved changelog for your readability and enjoyment updated the release date finalizing the changelog with a few more edits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
The Jetpack Site Icon module was deprecated in 3.6.1. The transition logic deactivates the module for most sites, so the
jetpack_site_icon_urlfunction usually does not pass the existence check for most Jetpack sites.In any case, we plan toward moving to treating Site Icon as the canonical source of site's icon. The changes herein check for this option, falling back to the Jetpack-defined icon option if unset.
This improves consistency between Jetpack shadow sites and the remote site. Previously,
/me/sites(shadow site) will show the icon property for my Jetpack site, whereas/sites/%sdoes not (because the module is not active on the site).Testing instructions:
With changes applied to your Jetpack site, ensure that an icon property is consistently returned for Jetpack sites between
/me/sitesand/sites/%s. Authenticated requests can be issued using the Developer Site console to verify presence oficon.media_idwhen user has REST API media editing capabilities.Related: