Landing pages: a11y enhancements #5998
Merged
jeffgolenski merged 3 commits intomasterfrom Dec 29, 2016
Merged
Conversation
Apps Landing: adding proper titles to non-decorative svgs
Apps landing: Adding aria labels and titles to svgs for a11y
eliorivero
suggested changes
Dec 29, 2016
Contributor
eliorivero
left a comment
There was a problem hiding this comment.
Looking good! just a couple of changes to make.
_inc/client/apps/index.jsx
Outdated
| </p> | ||
|
|
||
| <img src={ imagePath + '/apps/triple-devices.svg' } className="jp-landing-apps__devices" /> | ||
| <img src={ imagePath + '/apps/triple-devices.svg' } className="jp-landing-apps__devices" role="img" alt="Example of three devices to use the WordPress apps. An iPhone, Android phone, and a apple laptop computer." /> |
Contributor
There was a problem hiding this comment.
Make alt attribute available for translation like alt={ __( 'string to translate' ) }
_inc/client/apps/index.jsx
Outdated
| <p className="jp-landing-apps__btn-container"> | ||
| <Button href="http://itunes.apple.com/us/app/wordpress/id335703880?mt=8" title={ __( 'WordPress.com in the App Store' ) } className="jp-app-button button-ios"> | ||
| <svg width="28" height="28" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 96 96"><path d="M74.7,62.2c-3.5-3.2-5.2-7.2-5.3-12.1c-0.1-6.2,2.8-11.1,8.5-14.5c-3.2-4.5-8-7.1-14.4-7.6c-2.4-0.2-5.2,0.3-8.7,1.5 | ||
| <svg width="28" height="28" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 96 96" aria-labelledby="wpcomIosbtn" role="img"><title id="wpcomIosbtn">Download the free WordPress app for your iPhone</title><path d="M74.7,62.2c-3.5-3.2-5.2-7.2-5.3-12.1c-0.1-6.2,2.8-11.1,8.5-14.5c-3.2-4.5-8-7.1-14.4-7.6c-2.4-0.2-5.2,0.3-8.7,1.5 |
Contributor
There was a problem hiding this comment.
This and other title tags should be available for translation.
Apps landing: adding proper syntax for translations of the title tags within svgs and alt tags
Member
Author
|
@eliorivero Good eye. I've added all the translation syntax to the title and alt tags. Can you give it another look? |
eliorivero
approved these changes
Dec 29, 2016
Contributor
|
merged to 4.5 479bf71 |
dereksmart
pushed a commit
that referenced
this pull request
Jan 17, 2017
CHangelog: add #5457 Changelog: add #5487 Changelog: add #5708 Changelog: add #5879 Changelog: add #5932 Changelog: add #5963 Changelog: add #5968 Changelog: add #5996 Changelog: add #5998 Changelog: add #5999 Changelog: add #6012 Changelog: add #6013 Changelog: add #6014 Changelog: add #6015 Changelog: add #6023 Changelog: add #6024 Changelog: add #6030 Changelog: add #5465 CHangelog: add #6063 Changelog: add #6025 Changelog: add #5974 Changelog: add #6059 Changelog: add #6046 Changelog: add #5418 Changelog: move things around and add missing information. Changelog: add #5565 Changelog: add #6087 Changelog: add #6095
dereksmart
pushed a commit
that referenced
this pull request
Jan 17, 2017
Changelog: add #5867 Changelog: add #5874 Changelog: add #5905 Changelog: add #5906 Changelog: add #5931 Changelog: add #5933 Changelog: add #5934 Bring over 4.4.2 changelog from branch-4.4 @see 18012a3 Changelog: add #5976, #5978, #5983 Changelog: add #5917 Changelog: add #5832 Changelog: add 4.4.2 release post link. CHangelog: add #5457 Changelog: add #5487 Changelog: add #5708 Changelog: add #5879 Changelog: add #5932 Changelog: add #5963 Changelog: add #5968 Changelog: add #5996 Changelog: add #5998 Changelog: add #5999 Changelog: add #6012 Changelog: add #6013 Changelog: add #6014 Changelog: add #6015 Changelog: add #6023 Changelog: add #6024 Changelog: add #6030 Changelog: add #5465 CHangelog: add #6063 Changelog: add #6025 Changelog: add #5974 Changelog: add #6059 Changelog: add #6046 Changelog: add #5418 Changelog: move things around and add missing information. Changelog: add #5565 Changelog: add #6087 Changelog: add #6095 Readme: add @tyxla to the list of contributors. Improved changelog for your readability and enjoyment updated the release date finalizing the changelog with a few more edits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4467
a11y enhancements for the apps landing page. adding title tags, alt tags, aria labels.
enhancements for the plans landing pages will come in another PR.
No visual changes.