Shortcodes: minify jQuery Cycle script#6024
Merged
dereksmart merged 3 commits intomasterfrom Jan 3, 2017
Merged
Conversation
lancewillett
reviewed
Jan 3, 2017
Contributor
lancewillett
left a comment
There was a problem hiding this comment.
I noticed the related test isn't active. Want to re-enable it?
modules/shortcodes/slideshow.php
Outdated
Contributor
There was a problem hiding this comment.
Do we need to bump the version number here to bust cache?
Contributor
|
Tested locally with Jetpack dev environment, works well. Going to give it a spin on WP.com test site also. |
lancewillett
reviewed
Jan 3, 2017
Contributor
lancewillett
left a comment
There was a problem hiding this comment.
Should the file be renamed to jquery.cycle.min.js instead?
Contributor
|
Tested successfully on WP.com. 👍 (I renamed the file there to add in Related WP.com code change (pending review): D3841-code |
a0d8020 to
99a6e3a
Compare
…te Scroll since it's not needed, the scripts are loaded when the post including the shortcode requires it.
310bcb2 to
4775c44
Compare
Contributor
Author
|
@lancewillett I have:
|
Contributor
|
@eliorivero Tests out both Jetpack local and on WP.com, looks great. |
Contributor
|
Nice, LGTM -- Thanks @lancewillett for testing on wpcom! |
Contributor
|
merged to 4.5 fb7e160 |
dereksmart
pushed a commit
that referenced
this pull request
Jan 17, 2017
CHangelog: add #5457 Changelog: add #5487 Changelog: add #5708 Changelog: add #5879 Changelog: add #5932 Changelog: add #5963 Changelog: add #5968 Changelog: add #5996 Changelog: add #5998 Changelog: add #5999 Changelog: add #6012 Changelog: add #6013 Changelog: add #6014 Changelog: add #6015 Changelog: add #6023 Changelog: add #6024 Changelog: add #6030 Changelog: add #5465 CHangelog: add #6063 Changelog: add #6025 Changelog: add #5974 Changelog: add #6059 Changelog: add #6046 Changelog: add #5418 Changelog: move things around and add missing information. Changelog: add #5565 Changelog: add #6087 Changelog: add #6095
dereksmart
pushed a commit
that referenced
this pull request
Jan 17, 2017
Changelog: add #5867 Changelog: add #5874 Changelog: add #5905 Changelog: add #5906 Changelog: add #5931 Changelog: add #5933 Changelog: add #5934 Bring over 4.4.2 changelog from branch-4.4 @see 18012a3 Changelog: add #5976, #5978, #5983 Changelog: add #5917 Changelog: add #5832 Changelog: add 4.4.2 release post link. CHangelog: add #5457 Changelog: add #5487 Changelog: add #5708 Changelog: add #5879 Changelog: add #5932 Changelog: add #5963 Changelog: add #5968 Changelog: add #5996 Changelog: add #5998 Changelog: add #5999 Changelog: add #6012 Changelog: add #6013 Changelog: add #6014 Changelog: add #6015 Changelog: add #6023 Changelog: add #6024 Changelog: add #6030 Changelog: add #5465 CHangelog: add #6063 Changelog: add #6025 Changelog: add #5974 Changelog: add #6059 Changelog: add #6046 Changelog: add #5418 Changelog: move things around and add missing information. Changelog: add #5565 Changelog: add #6087 Changelog: add #6095 Readme: add @tyxla to the list of contributors. Improved changelog for your readability and enjoyment updated the release date finalizing the changelog with a few more edits
zinigor
pushed a commit
that referenced
this pull request
Sep 8, 2017
…w minified resulting in faster loading times. Summary: Syncs changes in Jetpack to WP.com: #6024 Test Plan: 1. Apply patch to your WP.com sandbox (`arc patch D3841`). 2. Add a slideshow gallery to a post and verify it works normally. 3. Test with Infinite Scroll on and add a slideshow in a post that is displayed after IS fetches more entries and verify that both slideshows still work. Reviewers: jeherve, eliorivero Reviewed By: eliorivero Differential Revision: https://[private link] Merges r148465-wpcom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this on my new site elio.blog and searched for an issue here and there's this one that this PR now fixes #3335. I know that #5620 exists but I'm not sure if we need to minify these kind of files on each build since we won't be changing them often. So, here's this PR that specifically solves #3335.
Also, the reason why I noticed this script was because after running a test in the site I saw the script loaded, and I wasn't using it at all. I realized that when Infinite Scroll is supported, this script and others are always loaded. However, in my tests this wasn't true. I tested with this same branch and whenever the post that had a slideshow gallery was loaded, the script was loaded, so it's not necessary to always load it.
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes:
Shortcodes: the jQuery Cycle script used by slideshow galleries is now minified resulting in faster loading times.
cc @lancewillett for review