Skip to content

Carousel: fix potential infinite loop#5867

Merged
dereksmart merged 1 commit intomasterfrom
fix/infinite-loop-caoursel
Dec 13, 2016
Merged

Carousel: fix potential infinite loop#5867
dereksmart merged 1 commit intomasterfrom
fix/infinite-loop-caoursel

Conversation

@dereksmart
Copy link
Copy Markdown
Contributor

see r147257-wpcom for more details.

This was creating an infinite loop on posts that have attachments that were returning null.

@dereksmart dereksmart added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Dec 13, 2016
@dereksmart dereksmart added this to the 4.5 milestone Dec 13, 2016
Copy link
Copy Markdown
Contributor

@samhotchkiss samhotchkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@samhotchkiss samhotchkiss added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 13, 2016
@dereksmart dereksmart merged commit 066bd3a into master Dec 13, 2016
@dereksmart dereksmart deleted the fix/infinite-loop-caoursel branch December 13, 2016 22:11
@dereksmart dereksmart restored the fix/infinite-loop-caoursel branch December 13, 2016 22:11
@dereksmart dereksmart deleted the fix/infinite-loop-caoursel branch December 13, 2016 22:14
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Dec 21, 2016

Added to branch-4.5 in 112b250

jeherve added a commit that referenced this pull request Dec 21, 2016
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934

Bring over 4.4.2 changelog from branch-4.4

@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832

Changelog: add 4.4.2 release post link.

CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095

Readme: add @tyxla to the list of contributors.

Improved changelog for your readability and enjoyment

updated the release date

finalizing the changelog with a few more edits
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants