Skip to content

Jetpack Footer: shortened margin#5978

Merged
ashleighaxios merged 1 commit intomasterfrom
enhance/footer-margin-bottom
Dec 22, 2016
Merged

Jetpack Footer: shortened margin#5978
ashleighaxios merged 1 commit intomasterfrom
enhance/footer-margin-bottom

Conversation

@ashleighaxios
Copy link
Copy Markdown
Contributor

@ashleighaxios ashleighaxios commented Dec 21, 2016

Reduced the footer bottom margin from 4 to 2rems at the two largest
breakpoints. Fixes: #5977

Before:
screen shot 2016-12-21 at 5 07 23 pm

After:
screen shot 2016-12-21 at 5 37 30 pm

Reduced the footer bottom margin from 4 to 2rems at the two largest
breakpoints.
@ashleighaxios ashleighaxios self-assigned this Dec 21, 2016
@ashleighaxios ashleighaxios added Admin Page React-powered dashboard under the Jetpack menu General [Status] Design Polish [Status] Needs Design Review Design has been added. Needs a review! labels Dec 21, 2016
@ashleighaxios ashleighaxios added this to the 4.5 milestone Dec 21, 2016
@jeffgolenski
Copy link
Copy Markdown
Member

LGTM! Awesome work on your first Jetpack PR @ashleighaxios !!

@jeffgolenski jeffgolenski added [Status] Design Review Complete [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Design Review Design has been added. Needs a review! labels Dec 21, 2016
@rickybanister
Copy link
Copy Markdown

Awesome!

Copy link
Copy Markdown
Member

@jeffgolenski jeffgolenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ashleighaxios ashleighaxios merged commit 1b73ef3 into master Dec 22, 2016
@jeherve jeherve deleted the enhance/footer-margin-bottom branch December 23, 2016 11:42
jeherve added a commit that referenced this pull request Dec 23, 2016
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934

Bring over 4.4.2 changelog from branch-4.4

@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832

Changelog: add 4.4.2 release post link.

CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095

Readme: add @tyxla to the list of contributors.

Improved changelog for your readability and enjoyment

updated the release date

finalizing the changelog with a few more edits
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu General [Status] Design Review Complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jetpack footer spacing issue

4 participants