Skip to content

WordAds: Update Head Loader#13795

Merged
kraftbj merged 1 commit intomasterfrom
update/wordads-head-loader
Oct 24, 2019
Merged

WordAds: Update Head Loader#13795
kraftbj merged 1 commit intomasterfrom
update/wordads-head-loader

Conversation

@dbspringer
Copy link
Copy Markdown
Member

@dbspringer dbspringer commented Oct 21, 2019

IPW provided a new faster/less intensive method to load the ad head scripts, this replaces the head.js load in insert_head_iponweb. While we're at it, let's update the dns-prefetch hints to use the WP builtin wp_resource_hints filter.

Changes proposed in this Pull Request:

  • New faster, less intensive ad loading header script.
  • Utilize wp_resource_hints filter for dns-prefetches.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Update - p5UegX-qT-p2

Testing instructions:

  1. Load patch on Jetpack site with active WordAds module.
  2. Verify ads are still loading and dns-prefetch hints are in source.

Screen Shot 2019-10-21 at 2 46 25 PM

Proposed changelog entry for your changes:

  • Improved speed & resource use of Ads loading scripts.

@dbspringer dbspringer added [Status] Needs Review This PR is ready for review. [Feature] WordAds labels Oct 21, 2019
@dbspringer dbspringer added this to the 7.9 milestone Oct 21, 2019
@dbspringer dbspringer self-assigned this Oct 21, 2019
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Oct 21, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against cad313a

@jeherve jeherve added the Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Oct 22, 2019
jeherve
jeherve reviewed Oct 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I don't have any ads on my sites so I can't test all of it. I'll let someone else jump in. @kraftbj maybe, I think you have an active WordAds site?

@kraftbj kraftbj closed this Oct 24, 2019
@kraftbj kraftbj reopened this Oct 24, 2019
@kraftbj
Copy link
Copy Markdown
Contributor

kraftbj commented Oct 24, 2019

Misfired on the mouse.

A couple of issues that I don't think are related to the PR, just things the ad networks are doing:

The script from “https://secure.adnxs.com/bounce?%2Fasync_usersync%3Fcbfn%3DAN_async_load” was loaded even though its MIME type (“text/html”) is not a valid JavaScript MIME type. async_usersync.html

Loading mixed (insecure) display content “http://sync.go.sonobi.com/us.gif?nw=en&nuid=bdd883ce-ccca-4bcb-afe0-74f8c4570870” on a secure page

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 24, 2019
@kraftbj kraftbj merged commit ef248a1 into master Oct 24, 2019
@kraftbj kraftbj deleted the update/wordads-head-loader branch October 24, 2019 22:06
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 24, 2019
@dbspringer
Copy link
Copy Markdown
Member Author

dbspringer commented Oct 24, 2019

A couple of issues that I don't think are related to the PR, just things the ad networks are doing:

Yeah, it's possible one of the ad creatives is using junky calls, it happens way too often 😐 That should be unrelated to our side of the equation though.

jeherve added a commit that referenced this pull request Oct 28, 2019
@jeherve
Changelog: add #13795
7a80395
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve left review comments

@kraftbj kraftbj kraftbj approved these changes

@cphilleo cphilleo Awaiting requested review from cphilleo

@rclachance rclachance Awaiting requested review from rclachance

@phpmypython phpmypython Awaiting requested review from phpmypython

Assignees

@dbspringer dbspringer

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] WordAds

Projects

None yet

Milestone

7.9

Development

Successfully merging this pull request may close these issues.

5 participants

@dbspringer @jetpackbot @kraftbj @jeherve @matticbot