Skip to content

PHP 7.4 Compatibility: Remove deprecated array/string access syntax#13331

Merged
kraftbj merged 2 commits intomasterfrom
update/array-string-access-deprecation-for-php7.4
Sep 30, 2019
Merged

PHP 7.4 Compatibility: Remove deprecated array/string access syntax#13331
kraftbj merged 2 commits intomasterfrom
update/array-string-access-deprecation-for-php7.4

Conversation

@mdawaffe
Copy link
Copy Markdown
Member

@mdawaffe mdawaffe commented Aug 26, 2019

Changes proposed in this Pull Request:

PHP 7.4 deprecates the curly brace array/string access syntax:

$array{1}
$string{3}

https://wiki.php.net/rfc/deprecate_curly_braces_array_access

Switch to use the more-common square bracket syntax:

$array[1]
$string[3]

I used https://gist.github.com/theodorejb/763b83a43522b0fc1755a537663b1863 to find all the curly braces.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

No: Bug fix.

Testing instructions:

?

Proposed changelog entry for your changes:

  • Resolve deprecation warnings in anticipation of PHP 7.4.

@mdawaffe mdawaffe added the [Status] Needs Review This PR is ready for review. label Aug 26, 2019
@mdawaffe mdawaffe requested a review from a team August 26, 2019 21:26
@mdawaffe mdawaffe self-assigned this Aug 26, 2019
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Aug 26, 2019

Caution: This PR has changes that must be merged to WordPress.com
Hello mdawaffe! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D32032-code before merging this PR. Thank you!

@mdawaffe
Copy link
Copy Markdown
Member Author

mdawaffe commented Aug 26, 2019

I'm not sure how much of this should/can go to various upstream projects.

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Aug 26, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against 08b59cf

@kraftbj
Copy link
Copy Markdown
Contributor

kraftbj commented Sep 30, 2019

The CSS upstream projects are all generally abandoned or we're on pretty outdated versions (due to older PHP support, even still), so I don't think there is a need to upstream.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 30, 2019
@kraftbj kraftbj added this to the 7.9 milestone Sep 30, 2019
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Sep 30, 2019

mdawaffe, Your synced wpcom patch D32032-code has been updated.

kraftbj
kraftbj previously approved these changes Sep 30, 2019
View reviewed changes
@kraftbj kraftbj force-pushed the update/array-string-access-deprecation-for-php7.4 branch from 4ffcec0 to 5a5a324 Compare September 30, 2019 21:58
@kraftbj kraftbj merged commit def62d0 into master Sep 30, 2019
@kraftbj kraftbj deleted the update/array-string-access-deprecation-for-php7.4 branch September 30, 2019 22:33
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 30, 2019
jeherve added a commit that referenced this pull request Oct 23, 2019
@jeherve
Changelog: add #13331
0b23cb3
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@mdawaffe mdawaffe

Labels

[Feature] Custom CSS [Feature] Markdown [Feature] Shortcodes / Embeds [Status] Tested on WP.com [Type] Janitorial

Projects

None yet

Milestone

7.9

Development

Successfully merging this pull request may close these issues.

5 participants

@mdawaffe @matticbot @jetpackbot @kraftbj @jeherve