Connection: Redirect plugins and dashboard connect buttons to the main flow#13599
Merged
Connection: Redirect plugins and dashboard connect buttons to the main flow#13599
Conversation
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: October 1, 2019. |
Member
|
I went though and tested the flows and they worked as expected. Thanks for fixing all the minor things I found a long the way. |
Member
Author
|
Thanks for the review and for testing it Enej 🙌 |
jeherve
added a commit
that referenced
this pull request
Oct 29, 2019
* 7.9: Changelog * Update version number * Update stable tag and tested up to * Changelog: add #13530 * changelog: add #13578 * Changelog: add #13598 * Changelog: add entry for numerous block preview changes * Changelog: add #13599 * changelog: add #13541 * Changelog: add #13542 * Changelog: add #13331 * Changelog: add #13558 * Changelog: add #13409 * Changelog: add #13582 * Changelog: add #13600 * Changelog: add #13601 * Changelog: add #13595 * Changelog: add #12695 * Changelog: add #13009 * Changelog: add #13649 * Changelog: add #13450 * Changelog: add #13507 * Changelog: add #13658 * Changelog: add #13687 * changelog: add #13683 * Changelog: add #9323 * Changelog: add #13681 * Fix typos in readme * Add link to WordPress Beta Tester plugin * Changelog: add #13630 * Changelog: add #13695 * Changelog: add #13659 * Changelog: add #13716 * Changelog: add #13664 * Changelog: add #13682 * Changelog: add #13362 * Changelog: add #13563 * Add testing list for #13563 * Changelog: add #13735 * Changelog: add #13752 * Changelog: add #13624 * Changelog: add #13756 * Changelog: add #13745 * Changelog: add #13728 * Changelog: add #13779 * Changelog: add #13699 * Changelog: add #13804 * Changelog: add #13761 * Changelog: add #13637 * Changelog: add #13517 * Changelog: add #13521 * Changelog: add #13729 * Testing list: add testing instructions for #13729 * Changelog: add sync changes * Changelog: add #13807 * Changelog: add #13654 * Changelog: add #13795 * Changelog: add #13801 * Changelog: add #13818 * Changelog: add #13725 * Changelog: add #13831 * Changelog: add #13516 * Testing list: add Twenty Twenty instructions * Changelog: add #13799 * Changelog: add #13805 * Changelog: add #13688 * Changelog: add #13830
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the main connection flow starting from
/wp-admin/admin.php?page=jetpack#/has the connect-in-place flow, but the buttons starting from the WP-admin dashboard (/wp-admin/index.php) and plugins screen (/wp-admin/plugins.php) still work the old way.This PR updates these buttons so they respect the constant and A/B test, and based on them, redirect to either the original connection flow or the connect-in-place flow.
Changes proposed in this Pull Request:
JETPACK_SHOULD_USE_CONNECTION_IFRAMEconstant.jetpack_connect_in_place_v2A/B test.Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
npm build.define( 'JETPACK_SHOULD_USE_CONNECTION_IFRAME', true );/wp-admin/admin.php?page=jetpack#/master./wp-admin/index.php./wp-admin/admin.php?page=jetpack#/setup/wp-admin/plugins.php./wp-admin/admin.php?page=jetpack#/setupdefine( 'JETPACK_SHOULD_USE_CONNECTION_IFRAME', true );/wp-admin/admin.php?page=jetpack#//wp-admin/index.php./wp-admin/plugins.php.Proposed changelog entry for your changes: