Skip to content

Ensure password field is enabled when switching to u/p from SSO form#13687

Merged
gravityrail merged 1 commit intomasterfrom
try/fix-sso-login-password-disabled
Oct 7, 2019
Merged

Ensure password field is enabled when switching to u/p from SSO form#13687
gravityrail merged 1 commit intomasterfrom
try/fix-sso-login-password-disabled

Conversation

@gravityrail
Copy link
Copy Markdown
Contributor

@gravityrail gravityrail commented Oct 7, 2019

Fixes #13551

Changes proposed in this Pull Request:

  • Enable password input field when switching from SSO login form.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • If you're an Automattician, include a shortlink to the p2 discussion with Jetpack Product here.

Testing instructions:

  • On a site running the latest WordPress 5.3 nightly (5.3-beta2-46416) and 7.8...
  • Try to log in using /wp-login.php - everything should work
  • Enable "WordPress.com login" (aka SSO)
  • Try log log in using /wp-login.php - everything should STILL work

Proposed changelog entry for your changes:

  • Fix issue with disabled password field and SSO module enabled on WordPress 5.3+

@gravityrail gravityrail requested a review from a team October 7, 2019 21:30
@gravityrail gravityrail added [Feature] SSO [Status] Needs Review This PR is ready for review. labels Oct 7, 2019
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Oct 7, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 817ea34

kraftbj
kraftbj approved these changes Oct 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with latest stable and latest nightly WordPress. Confirmed the original issue on latest nightly. Confirmed the patch does not impact stable and console error free. Confirmed patch resolves issue on nightly.

We should definitely add this to the testing list, in part, to make sure changing in Core do not impact it between now and release.

@kraftbj kraftbj added [Pri] BLOCKER Bug When a feature is broken and / or not performing as intended [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 7, 2019
@gravityrail gravityrail merged commit 2aa6c93 into master Oct 7, 2019
@gravityrail gravityrail deleted the try/fix-sso-login-password-disabled branch October 7, 2019 23:00
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 7, 2019
@jeherve jeherve added this to the 7.9 milestone Oct 8, 2019
@jeherve jeherve added the [Status] Needs Testing We need to add this change to the testing call for this month's release label Oct 8, 2019
@jeherve jeherve added [Status] Has Changelog and removed [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release labels Oct 17, 2019
jeherve added a commit that referenced this pull request Oct 23, 2019
@jeherve
Changelog: add #13687
053bef4
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@gravityrail gravityrail

Labels

Bug When a feature is broken and / or not performing as intended [Feature] SSO [Pri] BLOCKER

Projects

None yet

Milestone

7.9

Development

Successfully merging this pull request may close these issues.

SSO: Password field disabled when using the WordPress nightly build

5 participants

@gravityrail @jetpackbot @kraftbj @jeherve @matticbot