Skip to content

Admin Page: translate empty Stats chart's message#13558

Merged
zinigor merged 3 commits intomasterfrom
fix/translate-chart-title
Oct 1, 2019
Merged

Admin Page: translate empty Stats chart's message#13558
zinigor merged 3 commits intomasterfrom
fix/translate-chart-title

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Sep 27, 2019

Changes proposed in this Pull Request:

  • This should allow us to translate the message appearing in the Jetpack Dashboard's Stats graph when there are no stats available:

image

Testing instructions:

  • Start from a new site in Spanish
  • Apply this branch.
  • Ensure that the message is still displayed (it won't be translated just yet, but it should still be displayed in English).

Proposed changelog entry for your changes:

  • Admin Page: translate empty Stats chart's message

@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Focus] i18n Internationalization / i18n, adaptation to different languages Admin Page React-powered dashboard under the Jetpack menu labels Sep 27, 2019
@jeherve jeherve added this to the 7.9 milestone Sep 27, 2019
@jeherve jeherve requested review from a team and oskosk September 27, 2019 08:34
@jeherve jeherve self-assigned this Sep 27, 2019
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Sep 27, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against e79d237

zinigor
zinigor suggested changes Sep 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch, but I have one suggestion.

@kraftbj kraftbj requested a review from zinigor September 30, 2019 20:53
@kraftbj
Copy link
Copy Markdown
Contributor

kraftbj commented Sep 30, 2019

Updated the import to the _x function. Marking as approved, but will leave it for someone else to merge as a check of my edit.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 30, 2019
@zinigor zinigor merged commit 26b9771 into master Oct 1, 2019
@zinigor zinigor deleted the fix/translate-chart-title branch October 1, 2019 07:04
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 1, 2019
jeherve added a commit that referenced this pull request Oct 2, 2019
@jeherve
Admin Page: define context properly in Stats graph.
7e53b8d 
Following up from #13558
@jeherve jeherve mentioned this pull request Oct 2, 2019
Merged
jeherve added a commit that referenced this pull request Oct 4, 2019
@jeherve
Admin Page: define context properly in Stats graph. (#13622)
23e1864 
Following up from #13558
jeherve added a commit that referenced this pull request Oct 23, 2019
@jeherve
Changelog: add #13558
7b980d5
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

@oskosk oskosk Awaiting requested review from oskosk

+1 more reviewer

@zinigor zinigor zinigor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended [Focus] i18n Internationalization / i18n, adaptation to different languages

Projects

None yet

Milestone

7.9

Development

Successfully merging this pull request may close these issues.

5 participants

@jeherve @jetpackbot @kraftbj @zinigor @matticbot