Photon: remove wp-dom-ready dependency#13624
Conversation
...this pulls in wp-polyfill which is a lot of kbs for nothing in Photon’s case since it’s ES5.
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: November 5, 2019. |
|
Reported in 2391475-zen |
|
Why does |
I don't think it should indeed: @youknowriad @gziolo do all the packages in core depend on |
Nope, it's hard to tell which packages require |
That's not necessarily the case outside of Gutenberg, though. Should these packages never be used outside of the editor? The photon change this PR reverts went from (in one file): to (in three files + 1 inline): (Go ahead and scroll those That's ~193 bytes to ~98,264 bytes, which seems excessive. I understand the value of using If we need to load |
Blocks depend on I agree it's quite extensive but there are not great alternatives neither so it ends up being a balance between developer experience or KBs. Photon code is ES5 so we "control" this there manually. The good news is that the dependency is shared between everything using it. |
|
Thanks @joendotcom, much appreciated! |
* 7.9: Changelog * Update version number * Update stable tag and tested up to * Changelog: add #13530 * changelog: add #13578 * Changelog: add #13598 * Changelog: add entry for numerous block preview changes * Changelog: add #13599 * changelog: add #13541 * Changelog: add #13542 * Changelog: add #13331 * Changelog: add #13558 * Changelog: add #13409 * Changelog: add #13582 * Changelog: add #13600 * Changelog: add #13601 * Changelog: add #13595 * Changelog: add #12695 * Changelog: add #13009 * Changelog: add #13649 * Changelog: add #13450 * Changelog: add #13507 * Changelog: add #13658 * Changelog: add #13687 * changelog: add #13683 * Changelog: add #9323 * Changelog: add #13681 * Fix typos in readme * Add link to WordPress Beta Tester plugin * Changelog: add #13630 * Changelog: add #13695 * Changelog: add #13659 * Changelog: add #13716 * Changelog: add #13664 * Changelog: add #13682 * Changelog: add #13362 * Changelog: add #13563 * Add testing list for #13563 * Changelog: add #13735 * Changelog: add #13752 * Changelog: add #13624 * Changelog: add #13756 * Changelog: add #13745 * Changelog: add #13728 * Changelog: add #13779 * Changelog: add #13699 * Changelog: add #13804 * Changelog: add #13761 * Changelog: add #13637 * Changelog: add #13517 * Changelog: add #13521 * Changelog: add #13729 * Testing list: add testing instructions for #13729 * Changelog: add sync changes * Changelog: add #13807 * Changelog: add #13654 * Changelog: add #13795 * Changelog: add #13801 * Changelog: add #13818 * Changelog: add #13725 * Changelog: add #13831 * Changelog: add #13516 * Testing list: add Twenty Twenty instructions * Changelog: add #13799 * Changelog: add #13805 * Changelog: add #13688 * Changelog: add #13830


Changes proposed in this Pull Request:
Follow-up from #13383
Remove wp-dom-ready dependency since it pulls in wp-polyfill which is a lot of kbs for nothing in Photon’s case since it’s ES5.
Testing instructions:
wp-polyfillandwp-dom-readyscripts load before this PR and with the change they're gone.Proposed changelog entry for your changes: