Skip to content

Sync: Ensure a post object is returned#13658

Merged
jeherve merged 2 commits intomasterfrom
fix/13657
Oct 7, 2019
Merged

Sync: Ensure a post object is returned#13658
jeherve merged 2 commits intomasterfrom
fix/13657

Conversation

@kraftbj
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj commented Oct 4, 2019

Fixes #13657

Changes proposed in this Pull Request:

  • Defensive coding for when a post is not returned from get_post.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • n/a

Testing instructions:

  • Don't have a specific testing steps. I presume something like publish a post, but before it syncs, delete it totally.

Proposed changelog entry for your changes:

  • Sync: Prevent a PHP Notice in some cases where a post isn't actually a post.

@kraftbj kraftbj added Bug When a feature is broken and / or not performing as intended [Status] In Progress [Package] Sync labels Oct 4, 2019
@kraftbj kraftbj added this to the 7.9 milestone Oct 4, 2019
@kraftbj kraftbj requested a review from a team October 4, 2019 19:22
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Oct 4, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against a61e2a5

@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Oct 4, 2019
@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Oct 4, 2019
mdawaffe
mdawaffe approved these changes Oct 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mdawaffe mdawaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I don't know how to reproduce, though. Do you think the notice from #13657 means that sync is broken for that site?

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 7, 2019
@jeherve jeherve merged commit 3c9d9df into master Oct 7, 2019
@jeherve jeherve deleted the fix/13657 branch October 7, 2019 07:19
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 7, 2019
@jeherve jeherve removed the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Oct 7, 2019
@kraftbj
Copy link
Copy Markdown
Contributor Author

kraftbj commented Oct 7, 2019

Do you think the notice from #13657 means that sync is broken for that site?

In and of itself, I don't know. My best guess, since it is firing off of a post_id int value, the value being passed to it isn't a read post anymore. I could see something like a post that was created, sync was about to start, the post was fully deleted (so nothing in the db), sync still has the post in the queue, and the issue occurs. Maybe the post was deleted at exactly the right time or maybe deleted outside of the typical WP functions.

That's just a total guess though.

jeherve added a commit that referenced this pull request Oct 23, 2019
@jeherve
Changelog: add #13658
788510e
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdawaffe mdawaffe mdawaffe approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@kraftbj kraftbj

Labels

Bug When a feature is broken and / or not performing as intended [Package] Sync

Projects

None yet

Milestone

7.9

Development

Successfully merging this pull request may close these issues.

Sync: PHP Notice

5 participants

@kraftbj @jetpackbot @mdawaffe @jeherve @matticbot