Skip to content

fix: Allow specFileRetries to be overriden in the beforeSession hook#14859

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
bgrozev:fix-specFileRetries
Jan 8, 2026
Merged

fix: Allow specFileRetries to be overriden in the beforeSession hook#14859
christian-bromann merged 1 commit intowebdriverio:mainfrom
bgrozev:fix-specFileRetries

Conversation

@bgrozev
Copy link
Contributor

@bgrozev bgrozev commented Nov 14, 2025

This fixes #14842.

This initializes the launcher's specFileRetries to -1 instead of reading from the config. The worker then reads the value from the config after running the beforeSession hook, and includes the value in the "sessionStarted" message, which is then passed back to the launcher when the worker ends.

This fixes webdriverio#14842.

This initializes the launcher's specFileRetries to -1 instead of reading
from the config. The worker then reads the value from the config after
running the beforeSession hook, and includes the value in the
"sessionStarted" message, which is then passed back to the launcher
when the worker ends.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 14, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: bgrozev / name: Boris Grozev (c057167)

Copy link
Contributor

@damencho damencho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with the example provided.

@bgrozev
Copy link
Contributor Author

bgrozev commented Dec 2, 2025

Can someone please review?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 667f9a2 into webdriverio:main Jan 8, 2026
3 checks passed
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 8, 2026
@wdio-bot
Copy link
Contributor

wdio-bot commented Jan 8, 2026

Hey bgrozev 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 9, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 9, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal pushed a commit to mccmrunal/webdriverio that referenced this pull request Jan 10, 2026
…ebdriverio#14859)

This fixes webdriverio#14842.

This initializes the launcher's specFileRetries to -1 instead of reading
from the config. The worker then reads the value from the config after
running the beforeSession hook, and includes the value in the
"sessionStarted" message, which is then passed back to the launcher
when the worker ends.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 10, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 10, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal pushed a commit to mccmrunal/webdriverio that referenced this pull request Jan 10, 2026
…ebdriverio#14859)

This fixes webdriverio#14842.

This initializes the launcher's specFileRetries to -1 instead of reading
from the config. The worker then reads the value from the config after
running the beforeSession hook, and includes the value in the
"sessionStarted" message, which is then passed back to the launcher
when the worker ends.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 12, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 12, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 13, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 13, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 13, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
christian-bromann pushed a commit that referenced this pull request Jan 13, 2026
…14998)

PR #14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 15, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
mccmrunal added a commit to mccmrunal/webdriverio that referenced this pull request Jan 15, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
christian-bromann pushed a commit that referenced this pull request Jan 17, 2026
* fix(jasmine-framework): move @types/jasmine to dependencies

Fixes #14475

* fix: Allow specFileRetries to be overriden in the beforeSession hook (#14859)

This fixes #14842.

This initializes the launcher's specFileRetries to -1 instead of reading
from the config. The worker then reads the value from the config after
running the beforeSession hook, and includes the value in the
"sessionStarted" message, which is then passed back to the launcher
when the worker ends.

* updated pnpm-lock

---------

Co-authored-by: bgrozev <boris@jitsi.org>
christian-bromann pushed a commit that referenced this pull request Jan 17, 2026
…14997)

* fix(local-runner): force kill stuck workers after shutdown timeout

* test(cli): fix launcher tests for specFileRetries -1 initialization

PR #14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
christian-bromann pushed a commit that referenced this pull request Jan 17, 2026
* fix(utils): preserve executeAsync timeout across retries

* test(cli): fix launcher tests for specFileRetries -1 initialization

PR #14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
christian-bromann added a commit that referenced this pull request Jan 17, 2026
)

* fix(jasmine,allure): preserve nested describe structure (#13953)

- Fix array mutation in Jasmine reporter
- Fix scope leak in Allure reporter
- Add regression tests

* test(cli): fix launcher tests for specFileRetries -1 initialization

PR #14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.

* Update packages/wdio-allure-reporter/src/state.ts

---------

Co-authored-by: Christian Bromann <git@bromann.dev>
christian-bromann pushed a commit that referenced this pull request Jan 17, 2026
#15012)

* fix(wdio-cli): ensure dynamic specs added in onPrepare are correctly counted

* test(cli): fix launcher tests for specFileRetries -1 initialization

PR #14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
christian-bromann pushed a commit that referenced this pull request Jan 17, 2026
#15010)

* fix(wdio-browser-runner): prioritize @tailwindcss/postcss for TailwindCSS v4 support (#14160)

* test(cli): fix launcher tests for specFileRetries -1 initialization

PR #14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
christian-bromann pushed a commit that referenced this pull request Feb 1, 2026
* fix: Allow specFileRetries to be overriden in the beforeSession hook (#14859)

This fixes #14842.

This initializes the launcher's specFileRetries to -1 instead of reading
from the config. The worker then reads the value from the config after
running the beforeSession hook, and includes the value in the
"sessionStarted" message, which is then passed back to the launcher
when the worker ends.

* test(cli): fix launcher tests for specFileRetries -1 initialization

PR #14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.

---------

Co-authored-by: bgrozev <boris@jitsi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expensable $15 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Overriding specFileRetries from beforeSession

4 participants