fix: Allow specFileRetries to be overriden in the beforeSession hook#14859
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Jan 8, 2026
Merged
fix: Allow specFileRetries to be overriden in the beforeSession hook#14859christian-bromann merged 1 commit intowebdriverio:mainfrom
christian-bromann merged 1 commit intowebdriverio:mainfrom
Conversation
This fixes webdriverio#14842. This initializes the launcher's specFileRetries to -1 instead of reading from the config. The worker then reads the value from the config after running the beforeSession hook, and includes the value in the "sessionStarted" message, which is then passed back to the launcher when the worker ends.
|
|
damencho
approved these changes
Nov 14, 2025
Contributor
damencho
left a comment
There was a problem hiding this comment.
Tested it with the example provided.
Contributor
Author
|
Can someone please review? |
Contributor
|
Hey bgrozev 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 9, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
13 tasks
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 9, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
mccmrunal
pushed a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 10, 2026
…ebdriverio#14859) This fixes webdriverio#14842. This initializes the launcher's specFileRetries to -1 instead of reading from the config. The worker then reads the value from the config after running the beforeSession hook, and includes the value in the "sessionStarted" message, which is then passed back to the launcher when the worker ends.
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 10, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 10, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
mccmrunal
pushed a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 10, 2026
…ebdriverio#14859) This fixes webdriverio#14842. This initializes the launcher's specFileRetries to -1 instead of reading from the config. The worker then reads the value from the config after running the beforeSession hook, and includes the value in the "sessionStarted" message, which is then passed back to the launcher when the worker ends.
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 12, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 12, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 13, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 13, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 13, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 15, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
mccmrunal
added a commit
to mccmrunal/webdriverio
that referenced
this pull request
Jan 15, 2026
PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
christian-bromann
pushed a commit
that referenced
this pull request
Jan 17, 2026
* fix(jasmine-framework): move @types/jasmine to dependencies Fixes #14475 * fix: Allow specFileRetries to be overriden in the beforeSession hook (#14859) This fixes #14842. This initializes the launcher's specFileRetries to -1 instead of reading from the config. The worker then reads the value from the config after running the beforeSession hook, and includes the value in the "sessionStarted" message, which is then passed back to the launcher when the worker ends. * updated pnpm-lock --------- Co-authored-by: bgrozev <boris@jitsi.org>
christian-bromann
pushed a commit
that referenced
this pull request
Jan 17, 2026
…14997) * fix(local-runner): force kill stuck workers after shutdown timeout * test(cli): fix launcher tests for specFileRetries -1 initialization PR #14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
christian-bromann
pushed a commit
that referenced
this pull request
Jan 17, 2026
* fix(utils): preserve executeAsync timeout across retries * test(cli): fix launcher tests for specFileRetries -1 initialization PR #14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
christian-bromann
added a commit
that referenced
this pull request
Jan 17, 2026
) * fix(jasmine,allure): preserve nested describe structure (#13953) - Fix array mutation in Jasmine reporter - Fix scope leak in Allure reporter - Add regression tests * test(cli): fix launcher tests for specFileRetries -1 initialization PR #14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior. * Update packages/wdio-allure-reporter/src/state.ts --------- Co-authored-by: Christian Bromann <git@bromann.dev>
christian-bromann
pushed a commit
that referenced
this pull request
Jan 17, 2026
#15012) * fix(wdio-cli): ensure dynamic specs added in onPrepare are correctly counted * test(cli): fix launcher tests for specFileRetries -1 initialization PR #14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
christian-bromann
pushed a commit
that referenced
this pull request
Jan 17, 2026
#15010) * fix(wdio-browser-runner): prioritize @tailwindcss/postcss for TailwindCSS v4 support (#14160) * test(cli): fix launcher tests for specFileRetries -1 initialization PR #14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior.
christian-bromann
pushed a commit
that referenced
this pull request
Feb 1, 2026
* fix: Allow specFileRetries to be overriden in the beforeSession hook (#14859) This fixes #14842. This initializes the launcher's specFileRetries to -1 instead of reading from the config. The worker then reads the value from the config after running the beforeSession hook, and includes the value in the "sessionStarted" message, which is then passed back to the launcher when the worker ends. * test(cli): fix launcher tests for specFileRetries -1 initialization PR #14859 changed specFileRetries initialization to -1 (unknown) to allow beforeSession hook to override it. The tests were not updated and still expected the config values (2, 3). This updates the test assertions to expect -1, matching the new initialization behavior. --------- Co-authored-by: bgrozev <boris@jitsi.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #14842.
This initializes the launcher's specFileRetries to -1 instead of reading from the config. The worker then reads the value from the config after running the beforeSession hook, and includes the value in the "sessionStarted" message, which is then passed back to the launcher when the worker ends.